Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.11 backports 2021-11-26 #18027

Merged
merged 30 commits into from Nov 30, 2021
Merged

v1.11 backports 2021-11-26 #18027

merged 30 commits into from Nov 30, 2021

Conversation

qmonnet
Copy link
Member

@qmonnet qmonnet commented Nov 26, 2021 •
edited by borkmann

Once this PR is merged, you can update the PR labels via:

$ for pr in 17983 17975 17973 17968 17969 17995 17993 17929 17813 17856 18008; do contrib/backporting/set-labels.py $pr done 1.11; done

@qmonnet qmonnet requested a review from a team November 26, 2021 16:50
@qmonnet qmonnet requested a review from a team as a code owner November 26, 2021 16:50
@qmonnet qmonnet requested a review from a team November 26, 2021 16:50
@qmonnet qmonnet requested review from a team as code owners November 26, 2021 16:50
@qmonnet qmonnet requested a review from a team November 26, 2021 16:50
@qmonnet qmonnet requested a review from a team as a code owner November 26, 2021 16:50
@qmonnet qmonnet requested a review from a team November 26, 2021 16:50
@qmonnet qmonnet requested a review from a team as a code owner November 26, 2021 16:50
@qmonnet qmonnet requested a review from a team November 26, 2021 16:50
@qmonnet qmonnet requested a review from a team as a code owner November 26, 2021 16:50
@qmonnet qmonnet requested a review from a team November 26, 2021 16:50
@qmonnet qmonnet added backport/1.11 This PR represents a backport for Cilium 1.11.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Nov 26, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 26, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot mentioned this pull request Nov 29, 2021
Closed
joestringer
joestringer approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the checkboxes, did we recently change that in the template? (If not, maybe we should :) )

aditighag
aditighag approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport of my PR looks good. Thanks!

@aanm
Copy link
Member

aanm commented Nov 30, 2021

@aanm
Copy link
Member

aanm commented Nov 30, 2021

The gke-stable failed because there was multiple IP addresses in cilium-host interface. I assume it will be fixed by #17762

@qmonnet
Copy link
Member Author

qmonnet commented Nov 30, 2021 •
edited

Thanks André! Summary:

I'm still struggling to triage the ConformanceKind1.19 and ConformanceGKE failures. @aanm can you also have a look at the CodeQL failure please? I'm not sure how I should handle it?

@qmonnet
Copy link
Member Author

qmonnet commented Nov 30, 2021

/test-gke

@qmonnet
Copy link
Member Author

qmonnet commented Nov 30, 2021

/test-1.17-4.9

@qmonnet
Copy link
Member Author

qmonnet commented Nov 30, 2021

/test-1.18-4.9

@qmonnet
Copy link
Member Author

qmonnet commented Nov 30, 2021

/test-1.19-4.9

@qmonnet
Copy link
Member Author

qmonnet commented Nov 30, 2021

/test-1.21-4.19

@qmonnet
Copy link
Member Author

qmonnet commented Nov 30, 2021

/test-1.22-4.9

@qmonnet
Copy link
Member Author

qmonnet commented Nov 30, 2021

/ci-gke-1.11

@qmonnet qmonnet mentioned this pull request Nov 30, 2021
Closed
@qmonnet
Copy link
Member Author

qmonnet commented Nov 30, 2021

The four Jenkins workflows that failed again all hit #18060 🤔
I've seen this on another PR so it's unlikely related to the current backport, though.

@aanm aanm merged commit 887f3d7 into cilium:v1.11 Nov 30, 2021
@qmonnet qmonnet deleted the pr/v1.11-backport-2021-11-26 branch November 30, 2021 17:00
nbusseneau added a commit to nbusseneau/cilium that referenced this pull request Nov 30, 2021
@nbusseneau
mlh: update Jenkins jobs following 1.23 support
850fd32 
Following merge of cilium#18027, we now support K8s 1.23 on branch 1.11 and
have rotated the Jenkins test jobs as follow:

- Changed: Kernel 4.9 testing on K8s 1.23 (instead of 1.22)
- Changed: Kernel 4.19 testing on K8s 1.22 (instead of 1.21)
- Changed: Kernel 5.4 testing on K8s 1.21 (instead of 1.20)
- Added: Kernel 4.9 testing on K8s 1.21

See the Table of Truth™️ for up to date status on CI testing:
https://docs.google.com/spreadsheets/d/1TThkqvVZxaqLR-Ela4ZrcJ0lrTJByCqrbdCjnI32_X0/edit#gid=0

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
@nbusseneau nbusseneau mentioned this pull request Nov 30, 2021
Merged
aanm pushed a commit that referenced this pull request Nov 30, 2021
@nbusseneau @aanm
mlh: update Jenkins jobs following 1.23 support
7ed8a42 
Following merge of #18027, we now support K8s 1.23 on branch 1.11 and
have rotated the Jenkins test jobs as follow:

- Changed: Kernel 4.9 testing on K8s 1.23 (instead of 1.22)
- Changed: Kernel 4.19 testing on K8s 1.22 (instead of 1.21)
- Changed: Kernel 5.4 testing on K8s 1.21 (instead of 1.20)
- Added: Kernel 4.9 testing on K8s 1.21

See the Table of Truth™️ for up to date status on CI testing:
https://docs.google.com/spreadsheets/d/1TThkqvVZxaqLR-Ela4ZrcJ0lrTJByCqrbdCjnI32_X0/edit#gid=0

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@jibi jibi jibi approved these changes

@brb brb brb approved these changes

@borkmann borkmann borkmann approved these changes

@joestringer joestringer joestringer approved these changes

@aanm aanm aanm approved these changes

@aditighag aditighag aditighag approved these changes

@errordeveloper errordeveloper Awaiting requested review from errordeveloper

@joamaki joamaki Awaiting requested review from joamaki

@tklauser tklauser Awaiting requested review from tklauser tklauser was automatically assigned from cilium/ci-structure

Assignees

@errordeveloper errordeveloper

@tklauser tklauser

@joamaki joamaki

Labels
backport/1.11 This PR represents a backport for Cilium 1.11.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet