Update k8s tests and libraries to v1.23.0-rc.0 #18008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
aanm
added
the
release-note/major
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
aanm
force-pushed
the
pr/update-k8s-version
branch
2 times, most recently
from
cedad81
to
3e03fd3
Compare
nbusseneau
approved these changes
Nov 25, 2021
There was a problem hiding this comment.
Code changes LGTM. I am making changes to Jenkins to add 1.23 and enable testing via /test-1.23-4.9.
Once this is actually merged or close to merging (depending if we want to test the rotated jobs before or after merging), we need to rotate the /test (master branch) Jenkins triggers and Jenkins pipelines. This entails:
- Adding Kernel 4.9 / K8s 1.23 testing
- Testing Kernel 4.19 on 1.22 instead of 1.21
- Testing Kernel 5.4 on 1.21 instead of 1.20
- Rolling back 1.21 to 4.9 kernel
- Updating the Table of Truth:tm:
- Update MLH config
- After updating triggers on Jenkins, trigger
/testat least once so that the jobs get registered on GH, then update GH PR status marked as required.
Please ping me on Slack when merging 🚀
|
/test-1.23-4.9 |
aanm
force-pushed
the
pr/update-k8s-version
branch
from
3e03fd3
to
ef279a5
Compare
|
/test-1.23-4.9 |
nbusseneau
reviewed
Nov 25, 2021
|
/test-1.23-4.9 |
aanm
force-pushed
the
pr/update-k8s-version
branch
2 times, most recently
from
c395a60
to
7bc89fa
Compare
|
/test-1.23-4.9 |
|
/test-upstream |
|
/test Job 'Cilium-PR-K8s-1.21-kernel-4.19' hit: #17881 (98.18% similarity) |
aanm
force-pushed
the
pr/update-k8s-version
branch
from
7bc89fa
to
244cd8b
Compare
|
Fixed all comments mentioned by Quentin. Doesn't require a new CI run. Merging since previously it was all green |
nbusseneau
added a commit
to nbusseneau/cilium
that referenced
this pull request
Nov 26, 2021
Following merge of cilium#18008, we now support K8s 1.22 and have rotated the Jenkins test jobs as follow: - Changed: Kernel 4.9 testing on K8s 1.23 (instead of 1.22) - Changed: Kernel 4.19 testing on K8s 1.22 (instead of 1.21) - Changed: Kernel 5.4 testing on K8s 1.21 (instead of 1.20) - Added: Kernel 4.9 testing on K8s 1.21 See the Table of Truth:tm: for up to date status on all trigger phrases: https://docs.google.com/spreadsheets/d/1TThkqvVZxaqLR-Ela4ZrcJ0lrTJByCqrbdCjnI32_X0/edit#gid=0 Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.11.0
aanm
pushed a commit
that referenced
this pull request
Nov 26, 2021
Following merge of #18008, we now support K8s 1.22 and have rotated the Jenkins test jobs as follow: - Changed: Kernel 4.9 testing on K8s 1.23 (instead of 1.22) - Changed: Kernel 4.19 testing on K8s 1.22 (instead of 1.21) - Changed: Kernel 5.4 testing on K8s 1.21 (instead of 1.20) - Added: Kernel 4.9 testing on K8s 1.21 See the Table of Truth:tm: for up to date status on all trigger phrases: https://docs.google.com/spreadsheets/d/1TThkqvVZxaqLR-Ela4ZrcJ0lrTJByCqrbdCjnI32_X0/edit#gid=0 Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
joestringer
added
backport-done/1.11
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.11
in 1.11.0
tklauser
added a commit
to cilium/cilium-cli
that referenced
this pull request
Dec 7, 2021
This pulls in k8s 1.23 (tagged as v0.24.0-alpha.0, see cilium/cilium#18008 (comment)) and thus requires some changes to corev1.Probe and corev1.Lifecycle instantiations. Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added a commit
to cilium/cilium-cli
that referenced
this pull request
Dec 7, 2021
This also pulls in k8s 1.23 (tagged as v0.24.0-alpha.0, see cilium/cilium#18008 (comment)) and thus requires some changes to corev1.Probe and corev1.Lifecycle instantiations. Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added a commit
to cilium/cilium-cli
that referenced
this pull request
Dec 7, 2021
This also pulls in k8s 1.23 (tagged as v0.24.0-alpha.0, see cilium/cilium#18008 (comment)) and thus requires some changes to corev1.Probe and corev1.Lifecycle instantiations. Signed-off-by: Tobias Klauser <tobias@cilium.io>
michi-covalent
pushed a commit
to cilium/cilium-cli
that referenced
this pull request
Dec 7, 2021
This also pulls in k8s 1.23 (tagged as v0.24.0-alpha.0, see cilium/cilium#18008 (comment)) and thus requires some changes to corev1.Probe and corev1.Lifecycle instantiations. Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added a commit
to cilium/hubble
that referenced
this pull request
Dec 8, 2021
This also pulls in k8s 1.23 (tagged as v0.24.0-alpha.0, see cilium/cilium#18008 (comment)). Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added a commit
to cilium/hubble
that referenced
this pull request
Dec 8, 2021
This also pulls in k8s 1.23 (tagged as v0.24.0-alpha.0, see cilium/cilium#18008 (comment)). Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added a commit
to cilium/hubble
that referenced
this pull request
Dec 8, 2021
This also pulls in k8s 1.23 (tagged as v0.24.0-alpha.0, see cilium/cilium#18008 (comment)). Signed-off-by: Tobias Klauser <tobias@cilium.io>
rolinh
pushed a commit
to cilium/hubble
that referenced
this pull request
Dec 8, 2021
This also pulls in k8s 1.23 (tagged as v0.24.0-alpha.0, see cilium/cilium#18008 (comment)). Signed-off-by: Tobias Klauser <tobias@cilium.io>
rolinh
pushed a commit
to cilium/hubble
that referenced
this pull request
Dec 8, 2021
This also pulls in k8s 1.23 (tagged as v0.24.0-alpha.0, see cilium/cilium#18008 (comment)). Signed-off-by: Tobias Klauser <tobias@cilium.io>
aditighag
pushed a commit
to aditighag/cilium-cli
that referenced
this pull request
Apr 21, 2023
This also pulls in k8s 1.23 (tagged as v0.24.0-alpha.0, see cilium/cilium#18008 (comment)) and thus requires some changes to corev1.Probe and corev1.Lifecycle instantiations. Signed-off-by: Tobias Klauser <tobias@cilium.io>
michi-covalent
pushed a commit
to michi-covalent/cilium
that referenced
this pull request
May 30, 2023
This also pulls in k8s 1.23 (tagged as v0.24.0-alpha.0, see cilium#18008 (comment)) and thus requires some changes to corev1.Probe and corev1.Lifecycle instantiations. Signed-off-by: Tobias Klauser <tobias@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: André Martins andre@cilium.io