Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#17813 v1.10 backport #18082

Merged
merged 5 commits into from
Dec 6, 2021
Merged

Conversation

jibi
Copy link
Member

@jibi jibi commented Dec 1, 2021

Once this PR is merged, you can update the PR labels via:

$ for pr in 17813; do contrib/backporting/set-labels.py $pr done 1.10; done

@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.10 kind/backports This PR provides functionality previously merged into master. labels Dec 1, 2021
nbusseneau added a commit to nbusseneau/cilium that referenced this pull request Dec 2, 2021
This backports cilium#17186 to `v1.10`.

Rationale: the original PR was required on `master` for cilium#17813. cilium#18082
is backporting cilium#17813 to `v1.10`, thus it also requires similar changes.

As we previously did on `master`, we switch the runtime tests to run on
net-next instead of 4.9 due to new unit tests requirements.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
joestringer pushed a commit that referenced this pull request Dec 2, 2021
This backports #17186 to `v1.10`.

Rationale: the original PR was required on `master` for #17813. #18082
is backporting #17813 to `v1.10`, thus it also requires similar changes.

As we previously did on `master`, we switch the runtime tests to run on
net-next instead of 4.9 due to new unit tests requirements.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
@jibi jibi force-pushed the pr/jibi/v1.10-egress-gw-refactoring branch 2 times, most recently from 32f0bdf to bdea975 Compare December 2, 2021 21:52
[ upstream commit 3ba8e6e ]

Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
[ upstream commit 2b07959 ]

to make it more clear it's related to the egress gateway policies

Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
[ upstream commit cdb4b46 ]

Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
[ upstream commit d9b60f7 ]

which will block the caller until the agent has fully sync its
k8s cache.

Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
[ upstream commit ed73a31 ]

This commit refactors the egress gateway manager in order to provide a
single `reconcile()` method  which will be invoked on all events
received by the manager. This method is responsible for adding and
removing entries to and from the egress policy map.

In addition to this, the manager will now wait for the k8s cache to be
fully synced before running its first reconciliation, in order to always
have the egress_policy map in a consistent state with the k8s
configuration.

Fixes: #17380
Fixes: #17753
Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
@jibi jibi force-pushed the pr/jibi/v1.10-egress-gw-refactoring branch from bdea975 to 229421d Compare December 6, 2021 10:11
@jibi
Copy link
Member Author

jibi commented Dec 6, 2021

/test-backport-1.10

@jibi
Copy link
Member Author

jibi commented Dec 6, 2021

/test-gke

@jibi jibi marked this pull request as ready for review December 6, 2021 16:02
@jibi jibi requested a review from a team as a code owner December 6, 2021 16:02
@jibi jibi requested a review from kkourt December 6, 2021 16:15
@nathanjsweet nathanjsweet merged commit f08ea1d into v1.10 Dec 6, 2021
@nathanjsweet nathanjsweet deleted the pr/jibi/v1.10-egress-gw-refactoring branch December 6, 2021 16:32
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants