test: Add Error Log Exceptions #18117
Conversation
nathanjsweet
added
area/CI
maintainer-s-little-helper
bot
assigned aanm, joestringer and pchaigno and unassigned aanm
There was a problem hiding this comment.
My take on this is that this is an error message which resolves itself, and causing CI to fail on this error message causes issues by itself without providing a useful way for developers to understand and attempt to resolve the issue. The log message is very specific to the leader election code in the operator (+ underlying k8s library). So, if we think this is benign then this is the right solution. If we think this error is not benign, then we should probably develop dedicated operator HA tests in order to catch any potential issues with those codepaths. In both cases it doesn't make sense to error out randomly in different tests on arbitrary contributors' PRs.
But I welcome input from the other reviewers as well before merging this.
Occasionally the cilium-operator will run into a transient issue where it cannot get/update/release the leaselock with K8s that it uses to adjudicate its leader election. This error message is part and parcel of this failure and can be ignored. cf. #16402 Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
pchaigno
force-pushed
the
pr/nathanjsweet/add-klog-resource-lock-exception-to-error-list-test-execeptions
branch
from
e9a25ec
to
2874bf9
Compare
|
I don't think we need to run the full end-to-end tests given this is a trivial change. All reviews are in, so marking ready to merge. The CodeQL failures are for code not touched in this pull request. |
pchaigno
added
the
ready-to-merge
nbusseneau
deleted the
pr/nathanjsweet/add-klog-resource-lock-exception-to-error-list-test-execeptions
branch
tklauser
added
backport-done/1.11
tklauser
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.7
tklauser
moved this from Needs backport from master
to Backport done to v1.11
in 1.11.1
joestringer
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.7
Occasionally the cilium-operator will run into a transient issue
where it cannot get/update/release the leaselock with K8s that
it uses to adjudicate its leader election. This error message
is part and parcel of this failure and can be ignored.
cf. #16402
Signed-off-by: Nate Sweet nathanjsweet@pm.me
Fixes: #17660.