Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: Promote controller-tools fork to cilium repo #18185

Merged

Conversation

christarazi
Copy link
Member

Move the fork of controller-tools from my personal fork to be officially
part of the Cilium repo.

Along the way, add the commit from
christarazi/controller-tools#1 to the v0.6.2
branch.

Updates: #12737

Move the fork of controller-tools from my personal fork to be officially
part of the Cilium repo.

Along the way, add the commit from
christarazi/controller-tools#1 to the v0.6.2
branch.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi requested a review from a team as a code owner December 8, 2021 22:08
@christarazi christarazi added release-note/misc This PR makes changes that have no direct user impact. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. kind/cleanup This includes no functional changes. needs-backport/1.11 labels Dec 8, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 8, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 8, 2021
@christarazi christarazi requested a review from aanm December 8, 2021 22:09
@christarazi
Copy link
Member Author

christarazi commented Dec 14, 2021

/test

Job 'Cilium-PR-K8s-1.22-kernel-4.19' failed and has not been observed before, so may be related to your PR:

Click to show.

Test Name

K8sFQDNTest Validate that FQDN policy continues to work after being updated

Failure Output

FAIL: Can't connect to a valid target when it should work

If it is a flake, comment /mlh new-flake Cilium-PR-K8s-1.22-kernel-4.19 so I can create a new GitHub issue to track it.

Job 'Cilium-PR-K8s-GKE' failed and has not been observed before, so may be related to your PR:

Click to show.

Test Name

K8sFQDNTest Validate that FQDN policy continues to work after being updated

Failure Output

FAIL: Can't connect to a valid target when it should work

If it is a flake, comment /mlh new-flake Cilium-PR-K8s-GKE so I can create a new GitHub issue to track it.

@christarazi
Copy link
Member Author

PR is not rebased (#18218) so that's why the CI has reported failures. Marking ready to merge as the change is low-risk anyway.

@christarazi christarazi added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Dec 16, 2021
@tklauser tklauser merged commit ddb5482 into cilium:master Dec 16, 2021
@christarazi christarazi deleted the pr/christarazi/controller-tools-gomod branch December 16, 2021 19:12
@qmonnet qmonnet added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants