Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.11 backports 2022-01-03 #18364

Merged
merged 9 commits into from
Jan 5, 2022

Conversation

christarazi
Copy link
Member

Once this PR is merged, you can update the PR labels via:

$ for pr in 18279 18185 18141 18305 18296; do contrib/backporting/set-labels.py $pr done 1.11; done

or with

$ make add-label branch=v1.11 issues=18279,18185,18141,18305,18296

pchaigno and others added 9 commits January 3, 2022 15:31
[ upstream commit 5a5755a ]

In a version vX.Y.Z, X is called the major version, Y the minor version,
and Z the patch version with this commit. Before this commit, Z was the
micro version, but that's a bit confusing given we already have 'minor'.

The patch terminology also matches semantics documented at semver.org.

Signed-off-by: Paul Chaignon <paul@cilium.io>
Signed-off-by: Chris Tarazi <chris@isovalent.com>
[ upstream commit ddb5482 ]

Move the fork of controller-tools from my personal fork to be officially
part of the Cilium repo.

Along the way, add the commit from
christarazi/controller-tools#1 to the v0.6.2
branch.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
Signed-off-by: Chris Tarazi <chris@isovalent.com>
[ upstream commit 6ee7914 ]

The annotations here should use the proper name for each CRD. Doing so
will make them shown up correctly in ArtifactHub, and will also simplify
automatic linting for when they are missing.

Signed-off-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Chris Tarazi <chris@isovalent.com>
[ upstream commit 6bee10d ]

These charts are intended to have annotations describing each CRD
installed by Cilium. Add EgressNATPolicy, which was previously missing.

Signed-off-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Chris Tarazi <chris@isovalent.com>
[ upstream commit 7349018 ]

These charts are intended to have annotations describing each CRD
installed by Cilium. Add CiliumEndpointSlices, which was previously
missing.

Signed-off-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Chris Tarazi <chris@isovalent.com>
[ upstream commit 99c034f ]

The Chart.yaml should have an annotation for each of the CRDs that
Cilium may install. Add a simple lint check to ensure this at build
time.

Signed-off-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Chris Tarazi <chris@isovalent.com>
[ upstream commit 227424a ]

The 0ffa7c6 commit didn't remove all guards which previously were
used to check that XDP is enabled only with |--devices| == 1.

The last guard was not visible on v1.11 due to
cilium#18304, while on v1.10 it failed on
the multi-dev XDP setups.

Fixes: 0ffa7c6 ("datapath,daemon: Enable multi-dev XDP")
Reported-by: Tobias Klauser <tobias@cilium.io>
Reported-by: Paul Chaignon <paul@cilium.io>
Signed-off-by: Martynas Pumputis <m@lambda.lt>
Signed-off-by: Chris Tarazi <chris@isovalent.com>
[ upstream commit bcb86c8 ]

* Fix for blocked state transition from ready-for-release to released
* Fix for unnecessary updates between agent and operator during handshake

Signed-off-by: Hemanth Malla <hemanth.malla@datadoghq.com>
Signed-off-by: Chris Tarazi <chris@isovalent.com>
[ upstream commit 2581084 ]

crdAllocator.Allocate() aquires lock on allocator first and then on
nodestore. But updateLocalNodeResource() acquires locks in the opposite
order. This commit releases nodestore lock before acquiring allocator lock
to avoid potential deadlocks due to inconsistent lock ordering.

Signed-off-by: Hemanth Malla <hemanth.malla@datadoghq.com>
Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi requested a review from a team as a code owner January 3, 2022 23:32
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.11 This PR represents a backport for Cilium 1.11.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Jan 3, 2022
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My change LGTM, thanks.

@christarazi
Copy link
Member Author

/test-backport-1.11

@christarazi
Copy link
Member Author

Cilium L4LB XDP has been failing constantly which will be fixed by #18370. Merging.

@christarazi christarazi merged commit 2379544 into cilium:v1.11 Jan 5, 2022
@christarazi christarazi deleted the pr/v1.11-backport-2022-01-03 branch January 5, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.11 This PR represents a backport for Cilium 1.11.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants