Improvements to excess IP release handshake #18296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
gandro
added
area/eni
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
gandro
requested changes
Dec 20, 2021
hemanthmalla
force-pushed
the
hemanth.malla/handshake_improvements
branch
from
55ee370
to
0c8953f
Compare
gandro
reviewed
Dec 20, 2021
* Fix for blocked state transition from ready-for-release to released * Fix for unnecessary updates between agent and operator during handshake Signed-off-by: Hemanth Malla <hemanth.malla@datadoghq.com>
hemanthmalla
force-pushed
the
hemanth.malla/handshake_improvements
branch
from
0c8953f
to
fed1226
Compare
crdAllocator.Allocate() aquires lock on allocator first and then on nodestore. But updateLocalNodeResource() acquires locks in the opposite order. This commit releases nodestore lock before acquiring allocator lock to avoid potential deadlocks due to inconsistent lock ordering. Signed-off-by: Hemanth Malla <hemanth.malla@datadoghq.com>
gandro
approved these changes
Dec 21, 2021
|
/ci-eks |
|
/test-runtime |
|
Not running the full CI suite, as the none of the CRD-backed IPAM modes (eni, aks, plain crd) are covered by Jenkins at all. Once runtime is green, I think we can safely merge this. |
|
/ci-aks Edit: This workflow apparently was disabled. https://github.com/cilium/cilium/actions/workflows/conformance-aks.yaml |
|
Marking this ready to merge. As mentioned above, the code modified by this PR is not active in any currently enabled test suite except Ideally we had more coverage for the IP release feature as discussed in the last community meeting, but that should not block this bug fix from getting merged. |
gandro
added
the
ready-to-merge
qmonnet
added
the
backport-done/1.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #17939