daemon: Fix multi-dev XDP check #18305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brb
added
kind/bug
|
ci-l4lb |
brb
force-pushed
the
pr/brb/fix-multidev-xdp
branch
from
207ae6e
to
1af6d63
Compare
The 0ffa7c6 commit didn't remove all guards which previously were used to check that XDP is enabled only with |--devices| == 1. The last guard was not visible on v1.11 due to #18304, while on v1.10 it failed on the multi-dev XDP setups. Fixes: 0ffa7c6 ("datapath,daemon: Enable multi-dev XDP") Reported-by: Tobias Klauser <tobias@cilium.io> Reported-by: Paul Chaignon <paul@cilium.io> Signed-off-by: Martynas Pumputis <m@lambda.lt>
|
ci-l4lb |
|
/ci-l4lb |
|
ci-l4lb has passed. No need to run the whole suite. |
brb
added
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.7
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.7
This was referenced Jan 18, 2022
qmonnet
added
backport-done/1.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 0ffa7c6 commit didn't remove all guards which previously were
used to check that XDP is enabled only with |--devices| == 1.
The last guard was not visible on v1.11 due to
#18304, while on v1.10 it failed on
the multi-dev XDP setups.
Fixes: 0ffa7c6 ("datapath,daemon: Enable multi-dev XDP")
Reported-by: Tobias Klauser tobias@cilium.io
Reported-by: Paul Chaignon paul@cilium.io
Signed-off-by: Martynas Pumputis m@lambda.lt
Fix #18211