Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set debug.verbose to "flow" as a default for all CI runs #18431

Merged
merged 3 commits into from Jan 12, 2022
Merged

Set debug.verbose to "flow" as a default for all CI runs #18431

merged 3 commits into from Jan 12, 2022

Conversation

christarazi
Copy link
Member

@christarazi christarazi commented Jan 10, 2022 •
edited

  • test/helpers: Tidy up default Helm options
  • test: Default debug.verbose to "flow" for all CI runs
  • test/k8sT: Remove duplicated config inside Policies suite

Followup from #18333 (comment)

@christarazi christarazi requested a review from a team as a code owner January 10, 2022 21:20
@christarazi christarazi added area/CI-improvement Topic or proposal to improve the Continuous Integration workflow area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Jan 10, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 10, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 10, 2022
@christarazi christarazi changed the title pr/christarazi/cleanup ci options efault debug.verbose to "flow" for all CI runs Jan 10, 2022
@christarazi christarazi changed the title efault debug.verbose to "flow" for all CI runs Set debug.verbose to "flow" as a default for all CI runs Jan 10, 2022
@christarazi christarazi mentioned this pull request Jan 10, 2022
Merged
@christarazi
Copy link
Member Author

/test-me-please

1 similar comment
@christarazi
Copy link
Member Author

/test-me-please

@christarazi
Copy link
Member Author

/test

@christarazi
test/helpers: Tidy up default Helm options
c37c454 
Tidy them up for a future commit to add on to it.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi
test: Default debug.verbose to "flow" for all CI runs
45ff4d1 
Previously, this option was set arbitrarily inside the
DeployCiliumAndDNS() helper, which is used quite extensively throughout
the test suite. We might as well add it as a default Helm option, so
that it's used consistently.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi force-pushed the pr/christarazi/cleanup-ci-options branch from 101bd1b to 45ff4d1 Compare January 11, 2022 19:10
@christarazi
test/k8sT: Remove duplicated config inside Policies suite
181b316 
Now these options are set by default inside
DeployCiliumOptionsAndDNS(), so they no longer need to be set
explicitly.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi requested review from a team and jrajahalme January 11, 2022 20:46
@christarazi
Copy link
Member Author

Added test/k8sT: Remove duplicated config inside Policies suite now that #18333 has been merged.

@christarazi christarazi reopened this Jan 11, 2022
@christarazi
Copy link
Member Author

/test

@pchaigno pchaigno merged commit 8e052d7 into cilium:master Jan 12, 2022
@christarazi christarazi deleted the pr/christarazi/cleanup-ci-options branch January 12, 2022 21:09
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.11.1 Jan 12, 2022
@aditighag aditighag mentioned this pull request Jan 14, 2022
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.11.1 Jan 14, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Needs backport from master in 1.11.1 Jan 14, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Needs backport from master in 1.11.1 Jan 14, 2022
@christarazi christarazi mentioned this pull request Jan 18, 2022
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.11.1 Jan 18, 2022
@joestringer joestringer moved this from Backport pending to v1.10 to Backport pending to v1.11 in 1.11.1 Jan 18, 2022
@joestringer joestringer added this to Backport pending to v1.11 in 1.11.2 Jan 18, 2022
@joestringer joestringer removed this from Backport pending to v1.11 in 1.11.1 Jan 18, 2022
@kkourt kkourt added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Jan 20, 2022
@joestringer joestringer moved this from Backport pending to v1.11 to Backport done to v1.11 in 1.11.2 Feb 23, 2022
@joestringer joestringer mentioned this pull request Feb 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@nbusseneau nbusseneau nbusseneau approved these changes

@jrajahalme jrajahalme Awaiting requested review from jrajahalme

Assignees

@jrajahalme jrajahalme

Labels
area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.11.2
Backport done to v1.11
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@christarazi @pchaigno @nbusseneau @kkourt @jrajahalme @aditighag