[v1.11] Backport of #18431 #18509
Merged
[v1.11] Backport of #18431 #18509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit 043a6fb ] Tidy them up for a future commit to add on to it. Signed-off-by: Chris Tarazi <chris@isovalent.com>
[ upstream commit 88647b4 ] Previously, this option was set arbitrarily inside the DeployCiliumAndDNS() helper, which is used quite extensively throughout the test suite. We might as well add it as a default Helm option, so that it's used consistently. Signed-off-by: Chris Tarazi <chris@isovalent.com>
[ upstream commit 8e052d7 ] Now these options are set by default inside DeployCiliumOptionsAndDNS(), so they no longer need to be set explicitly. Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
added
backport/1.11
|
/test-backport-1.11 Job 'Cilium-PR-K8s-1.21-kernel-5.4' failed and has not been observed before, so may be related to your PR: Click to show.Test NameFailure OutputIf it is a flake, comment Job 'Cilium-PR-K8s-1.18-kernel-4.9' failed and has not been observed before, so may be related to your PR: Click to show.Test NameFailure OutputIf it is a flake, comment |
|
5.4 hit #17069. |
|
/mlh new-flake Cilium-PR-K8s-1.18-kernel-4.9 👍 created #18530 |
christarazi
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, you can update the PR labels via: