Revert "test: Add Error Log Exceptions" #18457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b73c5b1. Rationale: - The reverted commit on v1.10[1] was a backport of a master commit[2], itself building upon another master commit[3], both adding `level=error` checking to the CI. - [3] was not backported to v1.10, hence conflicts from backporting [2] to v1.10 were manually fixed, resulting in [1]'s description not matching its contents and also losing proper history tracing due to [3] not being present in the tree. - [1] introduced issue cilium#18285 in v1.10 CI tests. - It also appears [2] was not intended for backport in the first place. - Due to all of these, we revert [1] in v1.10. [1] b73c5b1 [2] 82d4422 [3] 11fb42a Note: a more thorough discussion can be found at cilium#18285 (comment) Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
nbusseneau
added
release-note/misc
maintainer-s-little-helper
bot
added
the
kind/backports
pchaigno
approved these changes
Jan 12, 2022
joestringer
approved these changes
Jan 12, 2022
|
Worth running CI for this revert? I would say no considering the nature of the flake, if you agree then we can mark as ready to merge. |
pchaigno
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b73c5b1.
Rationale:
level=errorchecking to the CI.[1] b73c5b1
[2] 82d4422
[3] 11fb42a
Note: a more thorough discussion can be found at #18285 (comment)