-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpf: Move to-stack trace after host firewall #18484
Conversation
Looks like k8s-1.22-kernel-4.19 (test-1.22-4.19) , k8s-1.23-kernel-net-next (test-1.23-net-next) and runtime (test-runtime) tests are failing. I think this is related to #18493. I'll rebase after it is merged. Otherwise, I think this PR is ready for review. |
0a68445
to
40af86a
Compare
Rebased the branch based on the latest master since #18493 is merged now. |
/test Job 'Cilium-PR-Runtime-net-next' hit: #18497 (97.23% similarity) Job 'Cilium-PR-K8s-1.22-kernel-4.19' failed and has not been observed before, so may be related to your PR: Click to show.Test Name
Failure Output
If it is a flake, comment Job 'Cilium-PR-K8s-1.23-kernel-net-next' failed and has not been observed before, so may be related to your PR: Click to show.Test Name
Failure Output
If it is a flake, comment |
/test Job 'Cilium-PR-Runtime-net-next' failed and has not been observed before, so may be related to your PR: Click to show.Test Name
Failure Output
If it is a flake, comment Job 'Cilium-PR-K8s-GKE' failed and has not been observed before, so may be related to your PR: Click to show.Test Name
Failure Output
If it is a flake, comment Job 'Cilium-PR-K8s-1.23-kernel-net-next' failed and has not been observed before, so may be related to your PR: Click to show.Test Name
Failure Output
If it is a flake, comment |
Failure in |
When host firewall feature is enable, to-stack trace can be generated even if the packets are rejected by host firewall policies. Generate trace only when the packets are actually delivered to the stack. Fixes: cilium#12562 Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
40af86a
to
2cad225
Compare
/test Job 'Cilium-PR-K8s-1.23-kernel-net-next' failed and has not been observed before, so may be related to your PR: Click to show.Test Name
Failure Output
If it is a flake, comment |
/test-1.23-net-next |
One minor, nit, I would try to create a user-facing release-note in the PR description, something like this should communicate the implications of the change correctly:
|
When host firewall feature is enable, to-stack trace can be generated
even if the packets are rejected by host firewall policies. Generate trace
only when the packets are actually delivered to the stack.
Fixes: #12562
Signed-off-by: Yutaro Hayakawa yutaro.hayakawa@isovalent.com
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXX
line if the commit addresses a particularGitHub issue.