-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update clustermesh example verification steps #18764
Conversation
Oh, looking at f81e8c6, it seems that this was intentional. @bmcustodio can you have a look, please? |
I am trying to remember the reason why I left the same definition on both files, but I can't remember. It can probably be removed (to be clear, I am talking about these bits). But I think that the reason indicated in the commit that @qmonnet mentioned is a valid one for us to leave the separate service definition as it is:
|
Thanks, let me reduce the scope of this PR :) |
This commit is to update verification command to avoid the need of passing pod name explicitly, so that it's easier for users to just copy and paste. Signed-off-by: Tam Mach <tam.mach@isovalent.com>
5c9db57
to
820e016
Compare
This commit is to update verification command to avoid the need
of passing pod name explicitly, so that it's easier for users to
just copy and paste.
Signed-off-by: Tam Mach tam.mach@isovalent.com