Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update clustermesh example verification steps #18764

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Feb 10, 2022

This commit is to update verification command to avoid the need
of passing pod name explicitly, so that it's easier for users to
just copy and paste.

Signed-off-by: Tam Mach tam.mach@isovalent.com

@sayboras sayboras requested a review from a team as a code owner February 10, 2022 12:52
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 10, 2022
@sayboras sayboras added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Feb 10, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 10, 2022
@qmonnet
Copy link
Member

qmonnet commented Feb 10, 2022

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.11.2 Feb 10, 2022
@qmonnet
Copy link
Member

qmonnet commented Feb 10, 2022

Oh, looking at f81e8c6, it seems that this was intentional. @bmcustodio can you have a look, please?

@bmcustodio
Copy link
Contributor

I am trying to remember the reason why I left the same definition on both files, but I can't remember. It can probably be removed (to be clear, I am talking about these bits). But I think that the reason indicated in the commit that @qmonnet mentioned is a valid one for us to leave the separate service definition as it is:

This allows for kubectl apply -f-ing the manifest directly in demo material or when users are trying things out. I guess it also allows for making it clearer in the documentation that the users actually must create the service in both clusters for load-balancing between clusters to work, as per the updated instructions.

@sayboras
Copy link
Member Author

This allows for kubectl apply -f-ing the manifest directly in demo material or when users are trying things out. I guess it also allows for making it clearer in the documentation that the users actually must create the service in both clusters for load-balancing between clusters to work, as per the updated instructions.

Thanks, let me reduce the scope of this PR :)

This commit is to update verification command to avoid the need
of passing pod name explicitly, so that it's easier for users to
just copy and paste.

Signed-off-by: Tam Mach <tam.mach@isovalent.com>
@sayboras sayboras changed the title docs: Cleanup clustermesh example deployment steps docs: Update clustermesh example verification steps Feb 10, 2022
@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 10, 2022
@jibi jibi merged commit 461d6d1 into cilium:master Feb 10, 2022
@sayboras sayboras deleted the tam/docs-clustermesh branch February 10, 2022 20:32
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.11.2 Feb 11, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.8 Feb 11, 2022
@jibi jibi added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Feb 14, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.11 in 1.11.2 Feb 14, 2022
@joestringer joestringer moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.8 Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.8
Backport done to v1.10
1.11.2
Backport done to v1.11
Development

Successfully merging this pull request may close these issues.

None yet

4 participants