v1.10 backports 2022-04-19 #19482
Merged
v1.10 backports 2022-04-19 #19482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
backport/1.10
kind/backports
|
/test-backport-1.10 |
|
/test-gke Looks like CI images were not ready. |
pchaigno
reviewed
Apr 19, 2022
pchaigno
approved these changes
Apr 19, 2022
|
/test-1.17-4.9 |
|
/test-1.18-4.9 |
|
/test-1.19-4.9 |
|
/test-1.21-4.9 |
1 similar comment
|
/test-1.21-4.9 |
|
/test-1.19-4.9 |
|
/test-1.17-4.9 |
|
Looks like we hit some BPF regeneration issue on all 4.9 jobs, e.g. https://jenkins.cilium.io/job/Cilium-PR-K8s-1.17-kernel-4.9/601/: Unfortunately artifacts containing the agent logs don't seem to be available on any of the jobs. I assume this is caused by the backport of #19308, so I'm dropping that commit to verify. |
[ upstream commit cfec27a ] This commit increases the VM boot timeout while decreasing the overall timeout :mindblown: We currently run the vagrant-ci-start.sh script with a 15m timeout and retry twice if it fails. That takes up to 45m in total if all attempts fail, as in frequently happening in CI right now. In particular, if the script simply fails because it's taking on average more than 15m then it is likely to fail all three times. This commit instead increases the timeout from 15m to 25m and removes the retries. The goal is obviously to succeed on the first try :p Ideally, we would investigate why it is now taking longer to start the VM. But this issue has been happening for a long time. And because of the retries, we probably didn't even notice the increase at the beginning: if it takes on average 15min, it might fail half the time and the test might still succeed most of the time. That is, the retries participate to hide the increase. Signed-off-by: Paul Chaignon <paul@cilium.io> Signed-off-by: Tobias Klauser <tobias@cilium.io>
[ upstream commit 29c3ebd ] Signed-off-by: André Martins <andre@cilium.io> Signed-off-by: Tobias Klauser <tobias@cilium.io>
[ upstream commit b7002f5 ] Use the correct terminology ('session affinity' vs 'service affinity'), and fix a typo. Signed-off-by: Julian Wiedmann <jwi@isovalent.com> Signed-off-by: Tobias Klauser <tobias@cilium.io>
[ upstream commit 6c34c93 ] Improve error logs thrown by port validation logic so that user can take necessary actions. Signed-off-by: Aditi Ghag <aditi@cilium.io> Signed-off-by: Tobias Klauser <tobias@cilium.io>
[ upstream commit 79d53af ] Local redirect policy requires Kube-proxy replacement, and the feature flag to be enabled. Rename the section that outlines these steps so that users are less likely to miss them. Suggested-by: Raymond de Jong <raymond.dejong@isovalent.com> Signed-off-by: Aditi Ghag <aditi@cilium.io> Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
force-pushed
the
pr/v1.10-backport-2022-04-19
branch
from
2fded9c
to
7e4f324
Compare
|
/test-backport-1.10 |
|
/test-1.20-4.19 VM provisioning failed: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.20-kernel-4.19/1747/ |
aanm
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull skb data at the entrance of from-containter #19308 -- pull skb data at the entrance of from-containter (@liuyuan10)pull skb data at the entrance of from-containter #19308 (comment)
Once this PR is merged, you can update the PR labels via: