Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LRP minor improvements #19489

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

aditighag
Copy link
Member

No description provided.

@aditighag aditighag requested a review from a team as a code owner April 19, 2022 21:51
@aditighag aditighag requested a review from a team April 19, 2022 21:51
@aditighag aditighag requested a review from a team as a code owner April 19, 2022 21:51
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 19, 2022
@aditighag aditighag requested a review from qmonnet April 19, 2022 21:51
@aditighag aditighag added the release-note/misc This PR makes changes that have no direct user impact. label Apr 19, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 19, 2022
@aditighag aditighag requested review from a team and raymonddejong April 19, 2022 21:53
Copy link
Contributor

@raymonddejong raymonddejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This improves understanding a lot.

Copy link
Contributor

@raymonddejong raymonddejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Please find some (non-blocking) suggestions below.

pkg/k8s/apis/cilium.io/v2/clrp_types.go Outdated Show resolved Hide resolved
pkg/k8s/apis/cilium.io/v2/clrp_types.go Outdated Show resolved Hide resolved
Improve error logs thrown by port
validation logic so that user can
take necessary actions.

Signed-off-by: Aditi Ghag <aditi@cilium.io>
@aditighag aditighag force-pushed the pr/aditighag/lrp-minor-improvements branch from 50b25b8 to c4ee135 Compare April 20, 2022 21:13
Local redirect policy requires Kube-proxy replacement, and
the feature flag to be enabled. Rename the section that
outlines these steps so that users are less likely to miss
them.

Suggested-by: Raymond de Jong <raymond.dejong@isovalent.com>
Signed-off-by: Aditi Ghag <aditi@cilium.io>
@aditighag aditighag force-pushed the pr/aditighag/lrp-minor-improvements branch from c4ee135 to f33d72f Compare April 20, 2022 21:18
@aditighag aditighag added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 20, 2022
@aditighag
Copy link
Member Author

No need to run the full CI pipeline since the PR only updates log messages, and documentation.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.11.5 Apr 20, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.16 Apr 20, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.11 Apr 20, 2022
@tklauser tklauser merged commit 79d53af into cilium:master Apr 20, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.11 Apr 21, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.11.5 Apr 21, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.11.5 Apr 21, 2022
@tklauser tklauser added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Apr 22, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.11 in 1.11.5 Apr 22, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.11 Apr 22, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.16 Apr 26, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.16 Apr 26, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.16 Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.11
Backport done to v1.10
1.11.5
Backport done to v1.11
1.9.16
Backport done to v1.9
Development

Successfully merging this pull request may close these issues.

None yet

6 participants