Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpf: Double timeout on building BPF programs #1949

Merged
merged 1 commit into from
Nov 2, 2017
Merged

Conversation

raybejjani
Copy link
Contributor

When a system is slow, or otherwise overloaded, the builds may take
longer. There isn't a fixed number however, so we are trying to be
forgiving.

Fixes #1653

I kept this simple, but it might be useful to have a backoff that goes up with timeouts, so we "discover" the optimum balance.

When a system is slow, or otherwise overloaded, the builds may take
longer. There isn't a fixed number however, so we are trying to be
forgiving.

Fixes #1653

Signed-off-by: Ray Bejjani <ray@covalent.io>
@raybejjani raybejjani requested a review from a team November 2, 2017 11:38
@raybejjani raybejjani requested a review from a team as a code owner November 2, 2017 11:38
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we think that a more interesting solution to this should be done at some point, would you consider filing an issue for that?

@tgraf tgraf added kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. labels Nov 2, 2017
@tgraf tgraf merged commit ce59ca7 into master Nov 2, 2017
@tgraf tgraf deleted the increase-bpf-timeout branch November 2, 2017 16:10
@raybejjani
Copy link
Contributor Author

@joestringer Do you mean file an issue now explaining the problem, and when a more complex solution would be needed? or wait and see then decide to make the ticket?
In any case, my expectation is that we will discover how often this occurs once we begin collecting metrics and when we see more deployments. I'm supposed to add metrics for all the things in the next week :)
Did you have something else in mind? I'm happy to make an issue out of it now if you want.

@joestringer
Copy link
Member

The "it might be useful to..." sentence in the description sounded like a future task that may or may not be tackled, depending on priorities, etc. If you're already planning to do the metrics stuff then it shouldn't be necessary.

@raybejjani
Copy link
Contributor Author

Ah, I see. I had a "double the backoff on each failure" scheme in mind, but I would prefer to have some metrics around the build time to begin with. In fact, thinking on it more, if we collect metrics anyway (a task I have on my list already) then we can make the backoff 90th percentile or something like it to ensure most builds succeed but we don't wait forever for the outliers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase timeout when building programs
5 participants