Add Pull request and issue template #1951
Conversation
Signed-off-by: Thomas Graf <thomas@cilium.io>
Signed-off-by: Thomas Graf <thomas@cilium.io>
Signed-off-by: Thomas Graf <thomas@cilium.io>
tgraf
force-pushed
the
pull-request-template
branch
2 times, most recently
from
9faad95
to
b7983bd
Compare
tgraf
added
pending review
area/documentation
tgraf
added
the
release-note/minor
| https://github.com/cilium/cilium/blob/master/CONTRIBUTING.md for detailed instructions | ||
|
|
||
| --> | ||
|
|
There was a problem hiding this comment.
will the first lines show up when opening the PR? Looks like a HTML comment.
There was a problem hiding this comment.
I found this in other repositories that use this. We'll know soon.
There was a problem hiding this comment.
tried it now. It shows up.
.github/issue_template.md
Outdated
|
|
||
| - Cilium version (run `cilium version`) | ||
| - Kernel version (run `uname -a`) | ||
| - Orchestration system version in use (e.g. Kubernetes 1.7, Mesos, own) |
.github/issue_template.md
Outdated
| - Cilium version (run `cilium version`) | ||
| - Kernel version (run `uname -a`) | ||
| - Orchestration system version in use (e.g. Kubernetes 1.7, Mesos, own) | ||
| - Link to relevant artifacts (policies, deployments scripts, ...) |
There was a problem hiding this comment.
users: "What artifacts?" type an example of a command kubectl get cnp -o json
There was a problem hiding this comment.
Maybe we should defer requiring specific commands to be run until after have the bugtool (#1942) and then include what is left?
There was a problem hiding this comment.
That's true... looking through that list, should we also ask the users to paste the ip address show and ip route show?
There was a problem hiding this comment.
Yes, that's already on the list (ip r and ip a)
There was a problem hiding this comment.
I was asking if it should be on the issue template.
There was a problem hiding this comment.
I think we can use this for now. As people use this, we can update it to reflect what we think should be added over time.
.github/issue_template.md
Outdated
| - Cilium version (run `cilium version`) | ||
| - Kernel version (run `uname -a`) | ||
| - Orchestration system version in use (e.g. Kubernetes 1.7, Mesos, own) | ||
| - Link to relevant artifacts (policies, deployments scripts, ...) |
There was a problem hiding this comment.
I think we can use this for now. As people use this, we can update it to reflect what we think should be added over time.
tgraf
force-pushed
the
pull-request-template
branch
from
b7983bd
to
42bd363
Compare
Fixes: #1792