Disable Envoy version check if L7 proxy is disabled #20440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
pchaigno
added
area/proxy
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
pchaigno
reviewed
Jul 8, 2022
pchaigno
added
kind/bug
bmcustodio
force-pushed
the
pr/bruno/no-envoy-version-check-if-no-l7-proxy
branch
from
8345978
to
64a32ec
Compare
pchaigno
approved these changes
Jul 8, 2022
If '--enable-l7-proxy' is set to 'false', there is no point in performing the Envoy version check, and so it should be automatically disabled. One of the motivations for this change is that in some scenarios it's necessary to disable the L7 proxy to allow Cilium to start (eg. #17467), but specifying '--enable-l7-proxy=false' is not enough due to the version check still being performed in this situation. This commit attempts to improve the UX by disabling the version check if Envoy itself is disabled. Signed-off-by: Bruno M. Custódio <brunomcustodio@gmail.com>
bmcustodio
force-pushed
the
pr/bruno/no-envoy-version-check-if-no-l7-proxy
branch
from
64a32ec
to
c6523db
Compare
|
I don't think we need to run the end-to-end tests for this given it's only going to skip a check when l7Proxy is set. Smoke tests are passing and reviews are in, so marking ready to merge. |
pchaigno
added
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.12
in 1.12.0
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.12
in 1.12.0
aanm
added
backport-done/1.12
maintainer-s-little-helper
bot
moved this from Backport pending to v1.12
to Backport done to v1.12
in 1.12.0
tklauser
added
backport-done/1.11
tklauser
moved this from Needs backport from master
to Backport done to v1.11
in 1.11.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
--enable-l7-proxyis set tofalse, there is no point in performing the Envoy version check, and so it should be automatically disabled. One of the motivations for this change is that in some scenarios it's necessary to disable the L7 proxy to allow Cilium to start (eg. #17467), but specifying--enable-l7-proxy=falseis not enough due to the version check still being performed in this situation. This commit attempts to improve the UX by disabling the version check if Envoy itself is disabled.