Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a section with distro-specific considerations #21064

Merged
merged 1 commit into from Oct 21, 2022

Conversation

bmcustodio
Copy link
Contributor

Over time we've been accumulating some knowledge about particular
Linux distributions and groups of distributions that has gone largely
unnoted in our documentation. A good understanding and implementation
of these considerations are extremely important to ensure that Cilium
runs properly, so this commit attempts at adding a subsection containing
this information.

@bmcustodio bmcustodio added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.10 labels Aug 24, 2022
@bmcustodio bmcustodio requested review from a team as code owners August 24, 2022 08:25
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.15 Aug 24, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.12.2 Aug 24, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.11.9 Aug 24, 2022
@bmcustodio
Copy link
Contributor Author

Adding @gandro (for Flatcar) and @borkmann (for new systemd notes) as reviewers as we've discussed these in some form over time.

Copy link
Member

@borkmann borkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! The section likely applies to any distro that's using systemd-networkd as the default, but Flatcar is the only one we've observed this so far I think.

Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of documenting, should we instead do a PR similar to #20072?

Documentation/operations/system_requirements.rst Outdated Show resolved Hide resolved
@nebril nebril added this to Needs backport from master in 1.10.16 Sep 14, 2022
@nebril nebril removed this from Needs backport from master in 1.10.15 Sep 14, 2022
@nebril nebril added this to Needs backport from master in 1.11.10 Sep 14, 2022
@nebril nebril removed this from Needs backport from master in 1.11.9 Sep 14, 2022
@nebril nebril added this to Needs backport from master in 1.12.3 Sep 14, 2022
@nebril nebril removed this from Needs backport from master in 1.12.2 Sep 14, 2022
@pchaigno pchaigno marked this pull request as draft September 15, 2022 10:37
@qmonnet qmonnet added this to Needs backport from master in 1.10.17 Oct 11, 2022
@qmonnet qmonnet removed this from Needs backport from master in 1.10.16 Oct 11, 2022
@qmonnet qmonnet added this to Needs backport from master in 1.11.11 Oct 11, 2022
@qmonnet qmonnet removed this from Needs backport from master in 1.11.10 Oct 11, 2022
@qmonnet qmonnet added this to Needs backport from master in 1.12.4 Oct 12, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.17 Nov 9, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.11.11 Nov 9, 2022
@michi-covalent michi-covalent added this to Backport pending to v1.10 in 1.10.18 Nov 15, 2022
@michi-covalent michi-covalent removed this from Backport pending to v1.10 in 1.10.17 Nov 15, 2022
@michi-covalent michi-covalent added this to Backport pending to v1.12 in 1.12.5 Nov 16, 2022
@michi-covalent michi-covalent removed this from Backport pending to v1.12 in 1.12.4 Nov 16, 2022
@joestringer joestringer added this to Backport done to v1.10 in 1.10.17 Nov 18, 2022
@joestringer joestringer moved this from Backport pending to v1.10 to Backport done to v1.11 in 1.11.11 Nov 18, 2022
@joestringer joestringer added this to Backport done to v1.12 in 1.12.4 Nov 18, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport done to v1.11 to Backport pending to v1.10 in 1.11.11 Nov 18, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport done to v1.12 to Backport pending to v1.12 in 1.12.4 Nov 18, 2022
@joestringer joestringer moved this from Backport pending to v1.10 to Backport done to v1.11 in 1.11.11 Nov 18, 2022
@joestringer joestringer added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Nov 18, 2022
@joestringer joestringer moved this from Backport pending to v1.12 to Backport done to v1.12 in 1.12.4 Nov 18, 2022
@joestringer joestringer added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Nov 18, 2022
@joestringer joestringer removed this from Backport pending to v1.10 in 1.10.18 Nov 18, 2022
@joestringer joestringer removed this from Backport pending to v1.12 in 1.12.5 Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.17
Backport done to v1.10
1.11.11
Backport done to v1.11
1.12.4
Backport done to v1.12
Development

Successfully merging this pull request may close these issues.

None yet

7 participants