ingress: Rename LB annotation to annotation prefixes #21222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
sayboras
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
sayboras
force-pushed
the
tam/ingres-annotation-prefixes
branch
from
a7fd57d
to
f735c57
Compare
This is to avoid any potential confusion from user. Also, related docs are updated. Related: cilium#20860 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
force-pushed
the
tam/ingres-annotation-prefixes
branch
from
f735c57
to
9e2bf33
Compare
gandro
approved these changes
Sep 7, 2022
qmonnet
approved these changes
Sep 7, 2022
Right now, the original annotation changes are only available in master and 1.13.0-rc0, and this is a newly added feature, I don't think we need to highlight it in upgrade docs. |
christarazi
approved these changes
Sep 7, 2022
|
/test |
|
Tests are all passed, most of the reviews are in. Marking this ready to merge. In case of there is any other comments coming later, I will address in subsequent PRs. |
sayboras
added
ready-to-merge
maintainer-s-little-helper
bot
removed
the
ready-to-merge
nebril
added
backport-done/1.12
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport done to v1.12
in 1.12.2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport done to v1.12
in 1.12.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid any potential confusion from user. Also, related docs are updated.
Related: #20860
Signed-off-by: Tam Mach tam.mach@cilium.io