-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ingress: Rename LB annotation to annotation prefixes #21222
Conversation
a7fd57d
to
f735c57
Compare
This is to avoid any potential confusion from user. Also, related docs are updated. Related: cilium#20860 Signed-off-by: Tam Mach <tam.mach@cilium.io>
f735c57
to
9e2bf33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks.
Given that the Helm value has changed name, does it deserve a mention in the Upgrade Notes (Documentation/operations/upgrade.rst)?
Right now, the original annotation changes are only available in master and 1.13.0-rc0, and this is a newly added feature, I don't think we need to highlight it in upgrade docs. |
/test |
Tests are all passed, most of the reviews are in. Marking this ready to merge. In case of there is any other comments coming later, I will address in subsequent PRs. |
This is to avoid any potential confusion from user. Also, related docs are updated.
Related: #20860
Signed-off-by: Tam Mach tam.mach@cilium.io