Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cilium, bwm: Disable slow start after idle under pacing #21356

Merged
merged 1 commit into from
Sep 19, 2022
Merged

cilium, bwm: Disable slow start after idle under pacing #21356

merged 1 commit into from
Sep 19, 2022

Conversation

borkmann
Copy link
Member

No description provided.

@borkmann
cilium, bwm: Disable slow start after idle under pacing
be2d0eb 
For DC-like workloads this is recommended setting when also pacing infra
is in place, and helps to minimize TCP restart overhead. This is done as
extra setting under BBR as it brings the right underlying infra (fq, BPF
host routing to retain skb->sk till fq) and kernel dependencies (egress
tstamps).

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann borkmann requested a review from brb September 19, 2022 13:50
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 19, 2022
@borkmann borkmann marked this pull request as ready for review September 19, 2022 13:50
@borkmann borkmann requested a review from a team as a code owner September 19, 2022 13:50
@borkmann borkmann added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Sep 19, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 19, 2022
@borkmann borkmann added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Sep 19, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 19, 2022
@borkmann
Copy link
Member Author

borkmann commented Sep 19, 2022 •
edited by maintainer-s-little-helper bot

/test

Job 'Cilium-PR-K8s-1.25-kernel-net-next' hit: #21312 (96.29% similarity)

@maintainer-s-little-helper maintainer-s-little-helper bot mentioned this pull request Sep 19, 2022
Closed
@borkmann borkmann merged commit 103dea3 into master Sep 19, 2022
@borkmann borkmann deleted the pr/slowst branch September 19, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

Assignees
No one assigned
Labels
release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@borkmann @brb