Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: multi kernel DP conformance #21465

Merged
merged 1 commit into from
Nov 2, 2022
Merged

CI: multi kernel DP conformance #21465

merged 1 commit into from
Nov 2, 2022

Conversation

brb
Copy link
Member

@brb brb commented Sep 28, 2022 •
edited
Loading

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 28, 2022
@github-actions
Copy link

This pull request has been automatically marked as stale because it
has not had recent activity. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. and removed stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. labels Oct 29, 2022
@brb
github/workflows: Run DP conformance on multiple kernels
28b11c4 
Currently, the 4.19 is excluded for now, as it doesn't use kvm-clock as
a time source which is causing some stability issues.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb marked this pull request as ready for review November 1, 2022 16:15
@brb brb requested review from a team as code owners November 1, 2022 16:15
@brb brb added release-note/ci This PR makes changes to the CI. ci/hyperjump labels Nov 1, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 1, 2022
@brb brb added the area/CI-improvement Topic or proposal to improve the Continuous Integration workflow label Nov 1, 2022
aspsk
aspsk approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@aspsk aspsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor question about the timeout

.github/workflows/conformance-datapath.yaml
fail-fast: false
matrix:
kernel: ['5.4', '5.10', '5.15', 'bpf-next']
timeout-minutes: 120
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like 45 x 4? Was 45 too much?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean that GH can run this sequentially, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will be run in parallel. I set to 120min to catch some stability issues (TL;DR some VMs are still not using kvm-clock as a time source).

@brb brb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 2, 2022
@nbusseneau nbusseneau merged commit e25885f into master Nov 2, 2022
@nbusseneau nbusseneau deleted the pr/brb/ci-dp-matrix branch November 2, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aspsk aspsk aspsk approved these changes

@aanm aanm aanm approved these changes

@christarazi christarazi Awaiting requested review from christarazi christarazi was automatically assigned from cilium/ci-structure

Assignees
No one assigned
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow ci/hyperjump ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brb @aspsk @aanm @nbusseneau