helm: Add validation for Ingress Controller #21550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
sayboras
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
sayboras
added
area/helm
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
kaworu
approved these changes
Oct 3, 2022
This commit is to make sure that kubeProxyReplacement must be set to either 'partial' or 'strict' when Ingress Controller feature is enabled. This will help to highlight any potential issue earlier. Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
force-pushed
the
tam/helm-validation-ingress
branch
from
71c4386
to
50c1372
Compare
squeed
approved these changes
Oct 6, 2022
|
Reviews are in, changes are validated as part of GHA (e.g. Conformance Ingress jobs), marking this ready to merge. |
sayboras
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is to make sure that kubeProxyReplacement must be set to either 'partial' or 'strict' when Ingress Controller feature is enabled. This will help to highlight any potential issue earlier.
Signed-off-by: Tam Mach tam.mach@cilium.io