CODEOWNERS: Add ownerships for IPsec team #21567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
area/encryption
pchaigno
requested review from
a team and
YutaroHayakawa
and removed request for
a team
joestringer
requested changes
Oct 4, 2022
pchaigno
force-pushed
the
codeowners-ipsec-team
branch
from
449e0b1
to
2c3c124
Compare
It's not always possible to know, based on filenames only, if IPsec code was changed. This commit therefore tries to find a good balance, by requesting reviews of a pull request from the IPsec team only if the pull request is likely to have IPsec changes. The most controversial file is probably node.go but it contains critical IPsec logic; hence both datapath and IPsec team are requested on that file to be safe. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
codeowners-ipsec-team
branch
from
2c3c124
to
6637579
Compare
joestringer
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not always possible to know, based on filenames only, if IPsec code was changed. This commit therefore tries to find a good balance, by requesting reviews of a pull request from the IPsec team only if the pull request is likely to have IPsec changes.
The most controversial file is probably node.go but it contains critical IPsec logic; hence both datapath and IPsec team are requested on that file to be safe.