Documentation: Fix out-of-sync codeowners #21583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default make target is currently failing because 7335755 ("CODEOWNERS: Add ownerships for IPsec team") updated the CODEOWNERS file without regenerating the Documentation/codeowners.rst file. This commit it by regenerating the Documentation copy. This is covered in CI but as part of the Travis CI build only. I'm guessing we all missed it because we didn't expect tests to cover CODEOWNERS changes, and especially not Travis. Fixes: 7335755 ("CODEOWNERS: Add ownerships for IPsec team") Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
area/documentation
joestringer
approved these changes
Oct 4, 2022
|
Yeah, I must admit I would have thought that the Documentation/ targets would cover this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default make target is currently failing because 7335755 ("CODEOWNERS: Add ownerships for IPsec team") updated the
CODEOWNERSfile without regenerating theDocumentation/codeowners.rstfile. This commit it by regenerating the Documentation copy.This is covered in CI but as part of the Travis CI build only. I'm guessing we all missed it because we didn't expect tests to cover
CODEOWNERSchanges, and especially not Travis.Fixes: #21567.