-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator/metrics: Adjust bucket sizes #21860
Conversation
/lgtm |
f471c1d
to
ca6f286
Compare
Commits 76b1ca82dd4101334da1d77729d7a3d2d92d3f58, ca6f28688778dc9c15f850e29b0309464da671f0 do not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
ca6f286
to
e61110a
Compare
Thanks for the PR! |
/test Job 'Cilium-PR-K8s-1.23-kernel-5.4' failed: Click to show.Test Name
Failure Output
If it is a flake and a GitHub issue doesn't already exist to track it, comment Job 'Cilium-PR-K8s-1.24-kernel-4.19' failed: Click to show.Test Name
Failure Output
If it is a flake and a GitHub issue doesn't already exist to track it, comment |
e61110a
to
f066cc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, configurable buckets is a bigger topic, so we can defer that :)
f066cc4
to
617710a
Compare
No changes aside from removing |
617710a
to
1a3e8f6
Compare
I rebased the changes hoping that CI pipeline will pass this time, but now it looks like it requires some approval and/or is failing. Could you please take a look? I doubt this small change is causing any of the tests to fail |
1a3e8f6
to
ca353a9
Compare
In CiliumEndpointSliceDensity histogram buckets configuration option was unset, so defaults were used (they have values form 0 to 10 as seen here: https://pkg.go.dev/github.com/prometheus/client_golang/prometheus#pkg-variables). This change makes the width of the buckets 10 as documented. BUG=254474623 Signed-off-by: Aleksander Mistewicz <amistewicz@google.com>
In CiliumEndpointSliceQueueDelay histogram buckets configuration option was unset, so defaults were used (https://pkg.go.dev/github.com/prometheus/client_golang/prometheus#pkg-variables). This change doubles the number of buckets and increases the end of the last bucket to 1 hour as values larger than this can be observed in large clusters. Signed-off-by: Aleksander Mistewicz <amistewicz@google.com>
It gives nicer looking values than the computed version. Signed-off-by: Aleksander Mistewicz <amistewicz@google.com>
ca353a9
to
7e2d549
Compare
In
CiliumEndpointSliceDensity
histogram buckets configuration option was unset, so defaults were used (they have values form 0 to 10 as seen here: https://pkg.go.dev/github.com/prometheus/client_golang/prometheus#pkg-variables).This change makes the width of the buckets 10 as documented.
In
CiliumEndpointSliceQueueDelay
also defaults were used. After this change the largest bucket is 1 hour which corresponds to the values observed in large clusters while keeping granularity at small queue delays.Before:
(
cilium_operator_ces_queueing_delay_seconds
has the same default distribution)After: