Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: Remove chart fields planned for removal in 1.12 #21881

Merged
merged 1 commit into from
Nov 1, 2022
Merged

helm: Remove chart fields planned for removal in 1.12 #21881

merged 1 commit into from
Nov 1, 2022

Conversation

my-git9
Copy link
Contributor

@my-git9 my-git9 commented Oct 25, 2022

Remove chart fields planned for removal in 1.12

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Fixes: #issue-number

<!-- Enter the release note text here if needed or remove this section! -->

@my-git9 my-git9 requested review from a team as code owners October 25, 2022 14:48
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 25, 2022
@sayboras sayboras added area/helm Impacts helm charts and user deployment experience kind/cleanup This includes no functional changes. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Oct 25, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 25, 2022
@my-git9 my-git9 force-pushed the removevalue branch 2 times, most recently from 2314a94 to e0b8533 Compare October 25, 2022 15:47
@sayboras sayboras changed the title Remove chart fields planned for removal in 1.12 helm: Remove chart fields planned for removal in 1.12 Oct 26, 2022
@my-git9
Copy link
Contributor Author

my-git9 commented Oct 27, 2022 •
edited
Loading

The error report of ci seems to have nothing to do with the modification of this PR.

@my-git9
Copy link
Contributor Author

my-git9 commented Oct 31, 2022

Could you give some help for the failed test, thanks? @sayboras

@sayboras
Copy link
Member

Can you rebase with master ?

@my-git9
Copy link
Contributor Author

my-git9 commented Oct 31, 2022

Can you rebase with master ?

OK

@my-git9
Remove chart fields planned for removal in 1.12
9a22a05 
Signed-off-by: xin.li <xin.li@daocloud.io>
@my-git9
Copy link
Contributor Author

my-git9 commented Oct 31, 2022

Can you rebase with master ?

Thanks, all test has been pass

@joestringer joestringer merged commit 5a6b713 into cilium:master Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayboras sayboras sayboras approved these changes

@tommyp1ckles tommyp1ckles Awaiting requested review from tommyp1ckles tommyp1ckles was automatically assigned from cilium/sig-k8s

@gandro gandro Awaiting requested review from gandro gandro was automatically assigned from cilium/helm

Assignees
No one assigned
Labels
area/helm Impacts helm charts and user deployment experience kind/cleanup This includes no functional changes. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@my-git9 @sayboras @joestringer