Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add policy fuzzers #22038

Merged
merged 1 commit into from
Nov 29, 2022
Merged

add policy fuzzers #22038

merged 1 commit into from
Nov 29, 2022

Conversation

AdamKorcz
Copy link
Contributor

@AdamKorcz AdamKorcz commented Nov 7, 2022 •
edited
Loading

Signed-off-by: AdamKorcz adam@adalogics.com

Adds fuzzers that test whether cilium can crash after sanitizing a rule.

To test these fuzzers locally, run go test -fuzz=FuzzTestName, for example go test -fuzz=FuzzCiliumNetworkPolicyParse

@AdamKorcz AdamKorcz requested a review from a team as a code owner November 7, 2022 22:15
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 7, 2022
@AdamKorcz AdamKorcz force-pushed the cncf-fuzzing1 branch 2 times, most recently from d91775f to e1f4762 Compare November 9, 2022 15:29
@AdamKorcz AdamKorcz requested review from a team as code owners November 9, 2022 15:29
@AdamKorcz AdamKorcz requested a review from aanm November 9, 2022 15:29
@AdamKorcz AdamKorcz changed the title add policy fuzzer add policy fuzzers Nov 9, 2022
@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Nov 10, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 10, 2022
joestringer
joestringer reviewed Nov 14, 2022
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you share also instructions on how to use these fuzzers, ideally in the commit message?

pkg/policy/fuzz_test.go Show resolved Hide resolved
pkg/k8s/apis/cilium.io/v2/fuzz_test.go Show resolved Hide resolved
@joestringer joestringer self-assigned this Nov 14, 2022
@AdamKorcz
Copy link
Contributor Author

Could you share also instructions on how to use these fuzzers, ideally in the commit message?

Added in the commit message.

@joestringer
Copy link
Member

The CODEOWNERS check complains:

Error: Following files have no owners in CODEOWNERS:
test.txt

Should this be added to .gitignore?

Also, I don't see the instructions to test in the commit message, looks like it is only in the PR description. Could you put it into the commit message too?

The other failing tests look like known flakes #22217 and #22168 .

joestringer
joestringer requested changes Nov 21, 2022
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for the above.

@maintainer-s-little-helper
Copy link

Commit e40d99b9860c8821e42c0c54ec6494239818825a does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Nov 23, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Nov 23, 2022
@AdamKorcz AdamKorcz mentioned this pull request Nov 23, 2022
Merged
@joestringer
Copy link
Member

The test failure looks like it is caused by a breakage on the main branch, that is expected to be fixed here: #22337 . CODEOWNERS checks seem to be OK now so the testing aspect otherwise seems fine. Given that this is not hooked into CI on the Cilium repository side, I think this is OK to merge now.

@AdamKorcz @joestringer
add policy fuzzers
e8702f6 
Adds fuzzers that test whether cilium can crash after sanitizing a rule.

To test these fuzzers locally, run go test -fuzz=FuzzTestName, for example go test -fuzz=FuzzCiliumNetworkPolicyParse

Signed-off-by: AdamKorcz <adam@adalogics.com>
@joestringer joestringer merged commit 39c3a43 into cilium:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@aanm aanm aanm approved these changes

Assignees

@joestringer joestringer

Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdamKorcz @joestringer @aanm