Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add section to show how to customize cilium-agent metrics #22178

Merged
merged 1 commit into from
Nov 16, 2022
Merged

doc: add section to show how to customize cilium-agent metrics #22178

merged 1 commit into from
Nov 16, 2022

Conversation

ArthurChiao
Copy link
Contributor

Hello there,

Just add some guides on how to customize cilium-agent metric outputs that I think are helpful but which seems to haven't been covered in the current documentation.

Signed-off-by: ArthurChiao arthurchiao@hotmail.com

@ArthurChiao ArthurChiao requested review from a team as code owners November 15, 2022 08:55
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 15, 2022
@ArthurChiao ArthurChiao force-pushed the doc_add_custom_metrics_guide_github branch 2 times, most recently from e0ca3d4 to 275417e Compare November 15, 2022 10:39
joestringer
joestringer requested changes Nov 15, 2022
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! Just one minor wording nit below, could you fix that up?

Documentation/observability/metrics.rst Outdated Show resolved Hide resolved
@joestringer joestringer added release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.12 labels Nov 15, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 15, 2022
@ArthurChiao ArthurChiao force-pushed the doc_add_custom_metrics_guide_github branch from 2805f84 to b4ed23c Compare November 16, 2022 01:43
@ArthurChiao
doc: add section to show how to customize cilium-agent metrics
0d65828 
Signed-off-by: ArthurChiao <arthurchiao@hotmail.com>
@ArthurChiao ArthurChiao force-pushed the doc_add_custom_metrics_guide_github branch from b4ed23c to 0d65828 Compare November 16, 2022 01:44
@ArthurChiao
Copy link
Contributor Author

Thanks @joestringer! Just merged, squashed and rebased against latest master.

@ArthurChiao ArthurChiao requested review from joestringer and removed request for aditighag November 16, 2022 01:47
@joestringer joestringer added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 16, 2022
@tklauser tklauser merged commit 2fe3a92 into cilium:master Nov 16, 2022
@tklauser tklauser mentioned this pull request Nov 22, 2022
Merged
@jrajahalme jrajahalme added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Nov 24, 2022
@joestringer joestringer mentioned this pull request Dec 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

Assignees
No one assigned
Labels
backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArthurChiao @joestringer @tklauser @jrajahalme