ci/multicluster: Re-enable WireGuard testing #22815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandro
added
area/CI-improvement
PR #21080 fixed WireGuard connectivity issues when using kvstore mode. This likely also affected clustermesh, as we WireGuard was previously flaky in the clustermesh / multicluster conformance tests workflow. This commit re-enables the WireGuard-based connectivity test. Fixes: #18699 Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
WireGuard does not work with L7 proxy. Therefore, we manually disabled the L7 tests when running WireGuard-based connectivity tests. However, since Cilium CLI v0.12, it now auto-detects the presence of L7 policy support and skips the affected tests automatically. Therefore, there is no need to exclude those tests manually anymore. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
force-pushed
the
pr/gandro/re-enable-wireguard-in-multicluster-ci-v2
branch
from
072cac2
to
8e0ca2a
Compare
|
Test ran successfully ✔️ https://github.com/cilium/cilium/actions/runs/3748501475/jobs/6365918168#step:27:1 Removing the |
gandro
force-pushed
the
pr/gandro/re-enable-wireguard-in-multicluster-ci-v2
branch
from
8e0ca2a
to
145fac2
Compare
nebril
approved these changes
Jan 9, 2023
|
Marking this ready to merge there are no security relevant changes. Let's have this in master for a while before we backport it to the stable branches. |
gandro
added
the
ready-to-merge
aditighag
deleted the
pr/gandro/re-enable-wireguard-in-multicluster-ci-v2
branch
gandro
added a commit
to gandro/cilium
that referenced
this pull request
Jan 11, 2023
Seems to be failing pretty consistently since we reenabled it in cilium#22815. Let's disable it again and investigate. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
aditighag
pushed a commit
that referenced
this pull request
Jan 11, 2023
Seems to be failing pretty consistently since we reenabled it in #22815. Let's disable it again and investigate. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #21080 fixed WireGuard connectivity issues when using
kvstore mode. This likely also affected clustermesh, as WireGuard was
previously flaky in the clustermesh / multicluster conformance tests
workflow.
This commit re-enables the WireGuard-based connectivity test.
Fixes: #18699