Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add exception for etcd error #23334

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Conversation

aanm
Copy link
Member

@aanm aanm commented Jan 25, 2023

The etcd error 'Failed to update lock: etcdserver: request timed out' does not seem to be related with Cilium. Thus, we will add it to the list of exceptions and not fail the CI because of this error. This seems to be a consequence of etcd's errors such as:

  • 'Server.processUnaryRPC failed to write status: connection error: desc = "transport is closing"'
  • 'Failed to update lock: etcdserver: request timed out'

Those issues are referred in the etcd repository:

Signed-off-by: André Martins andre@cilium.io

Close #16402
Close #23047
Close #21175

The etcd error 'Failed to update lock: etcdserver: request timed out'
does not seem to be related with Cilium. Thus, we will add it to the
list of exceptions and not fail the CI because of this error. This seems
to be a consequence of etcd's errors such as:
 - 'Server.processUnaryRPC failed to write status: connection error: desc = "transport is closing"'
 - 'Failed to update lock: etcdserver: request timed out'

Those issues are referred in the etcd repository:
 - etcd-io/etcd#14071
 - etcd-io/etcd#14027 (comment)

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. needs-backport/1.11 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jan 25, 2023
@aanm aanm requested a review from a team as a code owner January 25, 2023 10:26
@aanm aanm requested a review from nebril January 25, 2023 10:26
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.11.13 Jan 25, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.12.6 Jan 25, 2023
@michi-covalent michi-covalent added this to Needs backport from master in 1.11.14 Jan 26, 2023
@michi-covalent michi-covalent removed this from Needs backport from master in 1.11.13 Jan 26, 2023
@michi-covalent michi-covalent added this to Needs backport from master in 1.12.7 Jan 26, 2023
@michi-covalent michi-covalent removed this from Needs backport from master in 1.12.6 Jan 26, 2023
@aanm aanm merged commit e3803b4 into cilium:master Jan 26, 2023
@qmonnet qmonnet mentioned this pull request Jan 30, 2023
9 tasks
@qmonnet qmonnet mentioned this pull request Jan 30, 2023
12 tasks
@qmonnet qmonnet mentioned this pull request Jan 31, 2023
27 tasks
@qmonnet qmonnet added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch backport-pending/1.11 labels Jan 31, 2023
@qmonnet qmonnet added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Feb 1, 2023
@joestringer joestringer moved this from Needs backport from master to Backport done to v1.11 in 1.11.14 Feb 13, 2023
@joestringer joestringer moved this from Needs backport from master to Backport done to v1.12 in 1.12.7 Feb 13, 2023
jibi added a commit that referenced this pull request Apr 4, 2023
Following up on #23334, add more exceptions for errors that seem to not
be related to Cilium but rather to etcd.

Fixes: #24701
Suggested-by: André Martins <andre@cilium.io>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
jibi added a commit that referenced this pull request Apr 4, 2023
Following up on #23334, add more exceptions for errors that seem to not
be related to Cilium but rather to etcd.

Fixes: #24701
Suggested-by: André Martins <andre@cilium.io>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
squeed pushed a commit that referenced this pull request Apr 5, 2023
Following up on #23334, add more exceptions for errors that seem to not
be related to Cilium but rather to etcd.

Fixes: #24701
Suggested-by: André Martins <andre@cilium.io>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
jibi added a commit that referenced this pull request Apr 5, 2023
[ upstream commit e773f7e ]

Following up on #23334, add more exceptions for errors that seem to not
be related to Cilium but rather to etcd.

Fixes: #24701
Suggested-by: André Martins <andre@cilium.io>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
jibi added a commit that referenced this pull request Apr 5, 2023
[ upstream commit e773f7e ]

Following up on #23334, add more exceptions for errors that seem to not
be related to Cilium but rather to etcd.

Fixes: #24701
Suggested-by: André Martins <andre@cilium.io>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
squeed pushed a commit that referenced this pull request Apr 6, 2023
[ upstream commit e773f7e ]

Following up on #23334, add more exceptions for errors that seem to not
be related to Cilium but rather to etcd.

Fixes: #24701
Suggested-by: André Martins <andre@cilium.io>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
squeed pushed a commit that referenced this pull request Apr 6, 2023
[ upstream commit e773f7e ]

Following up on #23334, add more exceptions for errors that seem to not
be related to Cilium but rather to etcd.

Fixes: #24701
Suggested-by: André Martins <andre@cilium.io>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
pchaigno pushed a commit to pchaigno/cilium that referenced this pull request Apr 11, 2023
[ upstream commit e773f7e ]

Following up on cilium#23334, add more exceptions for errors that seem to not
be related to Cilium but rather to etcd.

Fixes: cilium#24701
Suggested-by: André Martins <andre@cilium.io>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
Signed-off-by: Paul Chaignon <paul@cilium.io>
gandro pushed a commit that referenced this pull request Apr 13, 2023
[ upstream commit e773f7e ]

Following up on #23334, add more exceptions for errors that seem to not
be related to Cilium but rather to etcd.

Fixes: #24701
Suggested-by: André Martins <andre@cilium.io>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
Signed-off-by: Paul Chaignon <paul@cilium.io>
jrajahalme pushed a commit to jrajahalme/cilium that referenced this pull request May 22, 2023
[ upstream commit e773f7e ]

Following up on cilium#23334, add more exceptions for errors that seem to not
be related to Cilium but rather to etcd.

Fixes: cilium#24701
Suggested-by: André Martins <andre@cilium.io>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.11.14
Backport done to v1.11
1.12.7
Backport done to v1.12
3 participants