Skip to content

Commit

Permalink
tests: add exceptions for lease errors due to etcd
Browse files Browse the repository at this point in the history
[ upstream commit e773f7e ]

Following up on cilium#23334, add more exceptions for errors that seem to not
be related to Cilium but rather to etcd.

Fixes: cilium#24701
Suggested-by: André Martins <andre@cilium.io>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
  • Loading branch information
jibi authored and gandro committed Apr 13, 2023
1 parent ca5c025 commit 74f09c4
Showing 1 changed file with 11 additions and 9 deletions.
20 changes: 11 additions & 9 deletions test/helpers/cons.go
Original file line number Diff line number Diff line change
Expand Up @@ -233,14 +233,16 @@ const (
emptyIPNodeIDAlloc = "Attempt to allocate a node ID for an empty node IP address"

// ...and their exceptions.
opCantBeFulfilled = "Operation cannot be fulfilled on leases.coordination.k8s.io" // cf. https://github.com/cilium/cilium/issues/16402
initLeaderElection = "error initially creating leader election record: leases." // cf. https://github.com/cilium/cilium/issues/16402#issuecomment-861544964
globalDataSupport = "kernel doesn't support global data" // cf. https://github.com/cilium/cilium/issues/16418
removeInexistentID = "removing identity not added to the identity manager!" // cf. https://github.com/cilium/cilium/issues/16419
failedToListCRDs = "the server could not find the requested resource" // cf. https://github.com/cilium/cilium/issues/16425
retrieveResLock = "retrieving resource lock kube-system/cilium-operator-resource-lock" // cf. https://github.com/cilium/cilium/issues/16402#issuecomment-871155492
failedToRelLockEmptyName = "Failed to release lock: resource name may not be empty" // cf. https://github.com/cilium/cilium/issues/16402#issuecomment-985819560
failedToUpdateLockReqTimeout = "Failed to update lock: etcdserver: request timed out"
opCantBeFulfilled = "Operation cannot be fulfilled on leases.coordination.k8s.io" // cf. https://github.com/cilium/cilium/issues/16402
initLeaderElection = "error initially creating leader election record: leases." // cf. https://github.com/cilium/cilium/issues/16402#issuecomment-861544964
globalDataSupport = "kernel doesn't support global data" // cf. https://github.com/cilium/cilium/issues/16418
removeInexistentID = "removing identity not added to the identity manager!" // cf. https://github.com/cilium/cilium/issues/16419
failedToListCRDs = "the server could not find the requested resource" // cf. https://github.com/cilium/cilium/issues/16425
retrieveResLock = "retrieving resource lock kube-system/cilium-operator-resource-lock" // cf. https://github.com/cilium/cilium/issues/16402#issuecomment-871155492
failedToRelLockEmptyName = "Failed to release lock: resource name may not be empty" // cf. https://github.com/cilium/cilium/issues/16402#issuecomment-985819560
failedToUpdateLock = "Failed to update lock:"
failedToReleaseLock = "Failed to release lock:"
errorCreatingInitialLeader = "error initially creating leader election record:"

// HelmTemplate is the location of the Helm templates to install Cilium
HelmTemplate = "../install/kubernetes/cilium"
Expand Down Expand Up @@ -303,7 +305,7 @@ var badLogMessages = map[string][]string{
"DATA RACE": nil,
// Exceptions for level=error should only be added as a last resort, if the
// error cannot be fixed in Cilium or in the test.
"level=error": {opCantBeFulfilled, initLeaderElection, globalDataSupport, removeInexistentID, failedToListCRDs, retrieveResLock, failedToRelLockEmptyName, failedToUpdateLockReqTimeout},
"level=error": {opCantBeFulfilled, initLeaderElection, globalDataSupport, removeInexistentID, failedToListCRDs, retrieveResLock, failedToRelLockEmptyName, failedToUpdateLock, failedToReleaseLock, errorCreatingInitialLeader},
}

var ciliumCLICommands = map[string]string{
Expand Down

0 comments on commit 74f09c4

Please sign in to comment.