Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clustermesh requirements to mention node InternalIP explicitly #24164

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Update clustermesh requirements to mention node InternalIP explicitly #24164

merged 1 commit into from
Mar 10, 2023

Conversation

jspaleta
Copy link
Contributor

@jspaleta jspaleta commented Mar 3, 2023 •
edited by qmonnet
Loading

This is a one-line clustermesh documentation fix-up to be more explicit about what is required for clustermesh.

Discovered in a community slack discussion that k8s node ExternalIP isn't used by clustermesh.
Slack discussion reference:
https://cilium.slack.com/archives/C1MATJ5U5/p1677861317308659

docs: Update Cluster Mesh requirements to mention node InternalIP explicitly

@jspaleta
Update clustermesh requirements to mention node InternalIP explicitly
07c00a9 
Discovered in community slack that k8s node ExternalIP isn't used by clustermesh even if configured.  Let's be explicit about InternalIP in the documented reqs, until such time as use of node ExternalIP is supported.

Signed-off-by: Jef Spaleta <jspaleta@gmail.com>
@jspaleta jspaleta requested review from a team as code owners March 3, 2023 19:14
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 3, 2023
qmonnet
qmonnet approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/clustermesh Relates to multi-cluster routing functionality in Cilium. release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.11 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Mar 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.13.1 Mar 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.11.15 Mar 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.12.8 Mar 6, 2023
@jrajahalme jrajahalme merged commit 7dbc63a into cilium:master Mar 10, 2023
@nebril nebril added this to Needs backport from master in 1.11.16 Mar 10, 2023
@nebril nebril removed this from Needs backport from master in 1.11.15 Mar 10, 2023
@nebril nebril added this to Needs backport from master in 1.12.9 Mar 10, 2023
@nebril nebril removed this from Needs backport from master in 1.12.8 Mar 10, 2023
@tommyp1ckles tommyp1ckles mentioned this pull request Mar 11, 2023
Closed
4 tasks
@nebril nebril added this to Needs backport from master in 1.13.2 Mar 15, 2023
@nebril nebril removed this from Needs backport from master in 1.13.1 Mar 15, 2023
@giorio94 giorio94 mentioned this pull request Mar 16, 2023
Open
@NikAleksandrov NikAleksandrov mentioned this pull request Mar 20, 2023
Merged
5 tasks
@NikAleksandrov NikAleksandrov mentioned this pull request Mar 20, 2023
Merged
9 tasks
@NikAleksandrov NikAleksandrov mentioned this pull request Mar 23, 2023
Merged
29 tasks
@NikAleksandrov NikAleksandrov added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Mar 23, 2023
@youngnick youngnick added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.11 labels Mar 23, 2023
@jibi jibi added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Apr 7, 2023
@michi-covalent michi-covalent moved this from Needs backport from master to Backport done to v1.12 in 1.12.9 Apr 14, 2023
@michi-covalent michi-covalent mentioned this pull request Apr 14, 2023
Merged
@michi-covalent michi-covalent moved this from Needs backport from master to Backport done to v1.11 in 1.11.16 Apr 14, 2023
@michi-covalent michi-covalent mentioned this pull request Apr 14, 2023
Merged
@gentoo-root gentoo-root moved this from Needs backport from master to Backport done to v1.13 in 1.13.2 Apr 14, 2023
@gentoo-root gentoo-root mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrajahalme jrajahalme jrajahalme approved these changes

@qmonnet qmonnet qmonnet approved these changes

@YutaroHayakawa YutaroHayakawa Awaiting requested review from YutaroHayakawa YutaroHayakawa was automatically assigned from cilium/sig-clustermesh

Assignees
No one assigned
Labels
area/clustermesh Relates to multi-cluster routing functionality in Cilium. area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.11.16
Backport done to v1.11
1.12.9
Backport done to v1.12
1.13.2
Backport done to v1.13
cilium v1.13.2
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jspaleta @jrajahalme @qmonnet @jibi @NikAleksandrov @youngnick