v1.11 Backports 2023-03-20 #24458
Merged
v1.11 Backports 2023-03-20 #24458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikAleksandrov
requested review from
jspaleta,
christarazi,
pchaigno and
hemanthmalla
maintainer-s-little-helper
bot
added
backport/1.11
|
I had to fix up vp -> viper in the last commit 0557a2f ("Fix for disabled cloud provider rate limiting") |
|
Also noticed a typo in commit 93ebeb3 ("docs: Update the documentation for the conntrack-gc-interval flag") |
|
/test |
|
/ci-multicluster |
pchaigno
approved these changes
Mar 20, 2023
I'm first time tophat specifically for backports this week. :) |
hemanthmalla
approved these changes
Mar 20, 2023
|
My PR looks good. Thanks for backporting this. |
christarazi
approved these changes
Mar 20, 2023
[ upstream commit 7dbc63a ] Discovered in community slack that k8s node ExternalIP isn't used by clustermesh even if configured. Let's be explicit about InternalIP in the documented reqs, until such time as use of node ExternalIP is supported. Signed-off-by: Jef Spaleta <jspaleta@gmail.com>
[ upstream commit 9ac5b53 ] When using checker.ExportedEqual(), it was using the standard Equals checker under-the-hood, but this is incorrect. Fix it to use the correct checker. In the commit introducing the bug, there was no direct usage of checker.ExportedEqual(), but rather checker.ExportedEqual (note the plural). Subtle! Discovered while working on improving policy unit tests. Fixes: f4407e7 ("checker: Add ExportedEquals checker") Signed-off-by: Chris Tarazi <chris@isovalent.com> Signed-off-by: Nikolay Aleksandrov <nikolay@isovalent.com>
[ upstream commit 93ebeb3 ] The current documentation is incorrect as the default value is 0 and not 5 minutes. 0 implies a dynamic interval value, which this commit now documents. Signed-off-by: Paul Chaignon <paul@cilium.io> Signed-off-by: Nikolay Aleksandrov <nikolay@isovalent.com>
[ upstream commit 0557a2f ] Earlier versions of these flags had a prefix of ENI and were later renamed with a prefix of IPAM to be consistent across cloud providers. While removing the deprecated old flags, #12676 also removed lines needed for setting OperatorConfig struct fields from the values read in. This resulted in fields having golang defaults, which caused the rate limiter to be completely bypassed. Signed-off-by: Hemanth Malla <hemanth.malla@datadoghq.com> Signed-off-by: Nikolay Aleksandrov <nikolay@isovalent.com>
NikAleksandrov
force-pushed
the
pr/v1.11-backport-2023-03-20
branch
from
328bbc3
to
c0050d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--conntrack-gc-intervalflag #24400 (@pchaigno)Once this PR is merged, you can update the PR labels via:
or with