Avoid clearing objects in conversion funcs #24241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
|
Functionally a noop, so I don't think we need a changelog entry here. Tested on our biggest clusters as well, and we see no change. cc @aanm |
christarazi
added
kind/enhancement
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
christarazi
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
LGTM. I checked our other conversion functions and they are not doing the clearing either, so this seems sane to me.
cc @aanm
|
cc: @marseel , you'll be interested on this kubernetes/kubernetes#115658 |
This removes the behavior of mutating the objects received from the client-go library. To begin with there isn't really any benefit from doing so, given we don't store the object afterwards, and it will be ready for gc when it leaves the scope inside client-go. client-go can possibly return the same pointer twice here, to trigger eg. both an object update delta and then a DeletedFinalStateUnknown delta with the same pointer. For more info, see the issue 115658 in the kubernetes/kubernetes repo on github. Signed-off-by: Odin Ugedal <ougedal@palantir.com> Signed-off-by: Odin Ugedal <odin@uged.al>
|
Rebasing and running tests |
christarazi
force-pushed
the
remove-object-cleaning
branch
from
4f7db1d
to
8b6efad
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
aanm
added
needs-backport/1.11
needs-backport/1.13
aanm
added
backport-pending/1.13
aanm
added
backport-done/1.13
|
Sure looks like this also landed in v1.11 by now. |
julianwiedmann
added
backport-done/1.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the behavior of mutating the objects received from the client-go library. To begin with there isn't really any benefit from doing so, given we don't store the object afterwards, and it will be ready for gc when it leaves the scope inside client-go. client-go can possibly return the same pointer twice here, to trigger eg. both an object update delta and then a DeletedFinalStateUnknown delta with the same pointer.
For more info, see the issue 115658 in the kubernetes/kubernetes repo on github. (avoiding to link directly since it spamms the original issue).
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.