checker: Fix incorrect checker for ExportedEqual() #24373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using checker.ExportedEqual(), it was using the standard Equals checker under-the-hood, but this is incorrect. Fix it to use the correct checker. In the commit introducing the bug, there was no direct usage of checker.ExportedEqual(), but rather checker.ExportedEqual (note the plural). Subtle! Discovered while working on improving policy unit tests. Fixes: f4407e7 ("checker: Add ExportedEquals checker") Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
added
area/CI
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
|
cc @jrajahalme |
christarazi
added
needs-backport/1.11
needs-backport/1.13
nbusseneau
approved these changes
Mar 15, 2023
jrajahalme
approved these changes
Mar 15, 2023
christarazi
added
the
ready-to-merge
|
Marking ready to merge as we have approving reviews and we don't need a full CI run. |
5 tasks
9 tasks
29 tasks
NikAleksandrov
added
backport-pending/1.13
youngnick
added
backport-done/1.11
jibi
added
backport-done/1.13
This was referenced Apr 14, 2023
gentoo-root
moved this from Needs backport from master
to Backport done to v1.13
in 1.13.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using checker.ExportedEqual(), it was using the standard Equals
checker under-the-hood, but this is incorrect. Fix it to use the correct
checker.
In the commit introducing the bug, there was no direct usage of
checker.ExportedEqual(), but rather checker.ExportedEqual (note the
plural). Subtle!
Discovered while working on improving policy unit tests.
Fixes: f4407e7 ("checker: Add ExportedEquals checker")
Signed-off-by: Chris Tarazi chris@isovalent.com