Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update the documentation for the --conntrack-gc-interval flag #24400

Merged
merged 1 commit into from
Mar 16, 2023
Merged

docs: Update the documentation for the --conntrack-gc-interval flag #24400

merged 1 commit into from
Mar 16, 2023

Conversation

pchaigno
Copy link
Member

The current documentation is incorrect as the default value is 0 and not 5 minutes. 0 implies a dynamic interval value, which this commit now documents.

@pchaigno
docs: Update the documentation for the conntrack-gc-interval flag
8147882 
The current documentation is incorrect as the default value is 0 and not
5 minutes. 0 implies a dynamic interval value, which this commit now
documents.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. labels Mar 15, 2023
@pchaigno pchaigno requested a review from a team as a code owner March 15, 2023 22:18
@pchaigno pchaigno requested a review from qmonnet March 15, 2023 22:18
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 15, 2023
joestringer
joestringer approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks.

I'm not sure whether we should even be suggesting to tweak conntrack-gc-interval, such suggestions predate the dynamic heuristic. But this change by itself is at least more accurate than what we had before.

@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Mar 15, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 15, 2023
@joestringer joestringer added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. needs-backport/1.11 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Mar 15, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 15, 2023
@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 15, 2023
@aditighag aditighag merged commit 93ebeb3 into cilium:master Mar 16, 2023
@pchaigno pchaigno deleted the docs-update-conntrack-gc-interval branch March 16, 2023 18:41
@NikAleksandrov NikAleksandrov mentioned this pull request Mar 20, 2023
Merged
5 tasks
@NikAleksandrov NikAleksandrov mentioned this pull request Mar 20, 2023
Merged
9 tasks
@NikAleksandrov NikAleksandrov mentioned this pull request Mar 23, 2023
Merged
29 tasks
@NikAleksandrov NikAleksandrov added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Mar 23, 2023
@youngnick youngnick added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Mar 23, 2023
@jibi jibi added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Apr 7, 2023
This was referenced Apr 14, 2023
Merged
Merged
@gentoo-root gentoo-root mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@qmonnet qmonnet Awaiting requested review from qmonnet qmonnet was automatically assigned from cilium/docs-structure

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
No open projects
cilium v1.13.2
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pchaigno @joestringer @jibi @NikAleksandrov @youngnick @aditighag