Fix for disabled cloud provider rate limiting #24413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier versions of these flags had a prefix of ENI and were later renamed with a prefix of IPAM to be consistent across cloud providers. While removing the deprecated old flags, cilium#12676 also removed lines needed for setting OperatorConfig struct fields from the values read in. This resulted in fields having golang defaults, which caused the rate limiter to be completely bypassed. Signed-off-by: Hemanth Malla <hemanth.malla@datadoghq.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
hemanthmalla
added
affects/v1.11
gandro
added
needs-backport/1.11
needs-backport/1.13
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
gandro
approved these changes
Mar 16, 2023
|
Will make the backports once the PR is merged. |
If you intend to make the backports yourself, we should add the Note that we're not maintaining the v1.9 and v1.10 branches anymore, as they are EOL. |
|
/test |
christarazi
added
area/operator
squeed
approved these changes
Mar 17, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
5 tasks
9 tasks
29 tasks
NikAleksandrov
added
backport-pending/1.13
youngnick
added
backport-done/1.11
tklauser
removed
affects/v1.11
jibi
added
backport-done/1.13
This was referenced Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier versions of these flags had a prefix of ENI and were later renamed with a prefix of IPAM to be consistent across cloud providers. While removing the deprecated old flags, #12676 also removed lines needed for setting OperatorConfig struct fields from the values read in. This resulted in fields having golang defaults, which caused the rate limiter to be completely bypassed.