Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose bpf-lb-sock-hostns-only in cilium status #24570

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Expose bpf-lb-sock-hostns-only in cilium status #24570

merged 1 commit into from
Apr 4, 2023

Conversation

romanspb80
Copy link
Contributor

BPFSocketLBHostnsOnly is outputted in the Kube Proxy Replacement section in cilium status --verbose:

$ cilium status --verbose
[...]
KubeProxyReplacement Details:
[...]
BPFSocketLBHostnsOnly: Enabled
[...]

Fixes: #24160

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: #issue-number

<!-- Enter the release note text here if needed or remove this section! -->

@romanspb80 romanspb80 requested review from a team as code owners March 26, 2023 22:39
@romanspb80 romanspb80 requested a review from aanm March 26, 2023 22:39
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 26, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Mar 26, 2023
@aanm aanm added release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Mar 27, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 27, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.13.2 Mar 27, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.12.9 Mar 27, 2023
@aanm aanm requested a review from aditighag March 27, 2023 07:37
@aanm
Copy link
Member

aanm commented Mar 27, 2023

It seems the CI is failing due the changes made into this PR https://github.com/cilium/cilium/actions/runs/4526983771/jobs/7972485978?pr=24570

@romanspb80 romanspb80 force-pushed the Expose_bpf-lb-sock-hostns-only_in_cilium_status branch from 3f6ec94 to 09dec34 Compare March 27, 2023 22:40
aditighag
aditighag requested changes Mar 27, 2023
View reviewed changes
api/v1/models/kube_proxy_replacement.go Outdated
@@ -43,6 +43,9 @@ type KubeProxyReplacement struct {
// mode
// Enum: [Disabled Strict Probe Partial]
Mode string `json:"mode,omitempty"`

// flag bpf-lb-sock-hostns-only
BPFSocketLBHostnsOnly bool `json:"bpfSocketLBHostnsOnly,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go under KubeProxyReplacementFeatures (see above L 41). Please take a look at how other flags are exposed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've added the flag to the openapi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still not addressed. You've added the flag under KubeProxyReplacement, and not KubeProxyReplacementFeatures. Was there an issue in adding it under the latter?

borkmann
borkmann reviewed Mar 28, 2023
View reviewed changes
pkg/client/client.go Outdated Show resolved Hide resolved
@romanspb80 romanspb80 force-pushed the Expose_bpf-lb-sock-hostns-only_in_cilium_status branch from 09dec34 to 06f79f6 Compare March 29, 2023 19:58
@maintainer-s-little-helper
Copy link

Commit 06f79f622a1383ed41adf14a2149625716bf3885 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Mar 29, 2023
@romanspb80 romanspb80 force-pushed the Expose_bpf-lb-sock-hostns-only_in_cilium_status branch from 06f79f6 to b66913f Compare March 29, 2023 20:03
@maintainer-s-little-helper
Copy link

Commit b66913ff24048ebc0d24fb2c8637d2658a1c4b8b does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@romanspb80 romanspb80 requested review from borkmann and aditighag and removed request for borkmann March 29, 2023 20:04
aditighag
aditighag approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. LGTM... This is ready for merge once you add "Signed-off-by:" in the commit message.

aditighag
aditighag requested changes Mar 30, 2023
View reviewed changes
Copy link
Member

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#24570 (comment)

@romanspb80 romanspb80 force-pushed the Expose_bpf-lb-sock-hostns-only_in_cilium_status branch from b66913f to 10565d2 Compare March 30, 2023 18:38
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Mar 30, 2023
@romanspb80 romanspb80 force-pushed the Expose_bpf-lb-sock-hostns-only_in_cilium_status branch from 10565d2 to 9ba0d85 Compare March 31, 2023 17:28
@romanspb80
Expose bpf-lb-sock-hostns-only in cilium status
98a2046 
BPFSocketLBHostnsOnly is outputted in the Kube Proxy Replacement section in cilium status --verbose:

$ cilium status --verbose
[...]
KubeProxyReplacement Details:
  [...]
  Socket LB Coverage:     Hostns-only
  [...]

Fixes: cilium#24160

Signed-off-by: Roman Ptitcyn <romanspb@yahoo.com>
@romanspb80 romanspb80 force-pushed the Expose_bpf-lb-sock-hostns-only_in_cilium_status branch from 9ba0d85 to 98a2046 Compare March 31, 2023 17:28
@romanspb80
Copy link
Contributor Author

#24570 (comment)

I missed it (((.
Done. Pls, check

aditighag
aditighag approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Integration test failure is same as - #24653.
The PR is ready to merge.

@aditighag aditighag added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 4, 2023
@squeed squeed merged commit 60bb0ea into cilium:master Apr 4, 2023
@jibi jibi mentioned this pull request Apr 5, 2023
Merged
6 tasks
@jibi jibi added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Apr 5, 2023
@jibi jibi mentioned this pull request Apr 5, 2023
Merged
5 tasks
@jibi jibi added backport-pending/1.12 backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed needs-backport/1.12 backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Apr 5, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.12 in 1.12.9 Apr 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.13 in 1.13.2 Apr 7, 2023
@jibi jibi added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Apr 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.12 to Backport done to v1.12 in 1.12.9 Apr 7, 2023
@michi-covalent michi-covalent mentioned this pull request Apr 14, 2023
Merged
@gentoo-root gentoo-root mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkmann borkmann borkmann approved these changes

@aanm aanm aanm approved these changes

@aditighag aditighag aditighag approved these changes

Assignees
No one assigned
Labels
backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.12.9
Backport done to v1.12
1.13.2
Backport done to v1.13
cilium v1.13.2
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose bpf-lb-sock-hostns-only in cilium status
6 participants
@romanspb80 @aanm @borkmann @aditighag @jibi @squeed