Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.11 backports 2023-03-28 #24604

Merged
merged 6 commits into from
Mar 29, 2023

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Mar 28, 2023

Once this PR is merged, you can update the PR labels via:

$ for pr in 24460 24477 24435 23631 24557; do contrib/backporting/set-labels.py $pr done 1.11; done

Nikolay Aleksandrov and others added 6 commits March 28, 2023 12:28
[ upstream commit 986daf4 ]

contrack -> conntrack

Fixes: 93ebeb3 ("docs: Update the documentation for the conntrack-gc-interval flag")
Signed-off-by: Nikolay Aleksandrov <nikolay@isovalent.com>
Signed-off-by: Tobias Klauser <tobias@cilium.io>
[ upstream commit 30a783f ]

Renovate v35 had a breaking change in how it computes the digest of
GitHub releses. Previously, it would use the digest of the release
attachements, but now it's just using a git sha as the "digest". This
commit changes the data source for the Hubble artifacts to use the data
source which preserves the old behavior.

Ref: renovatebot/renovate#20178

Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
Signed-off-by: Tobias Klauser <tobias@cilium.io>
[ upstream commit b2bc42a ]

Signed-off-by: Liz Rice <liz@lizrice.com>
Signed-off-by: Tobias Klauser <tobias@cilium.io>
[ upstream commit e29c8ea ]

Support the case when ingress is configured to serve hubble-ui
from non default `/` root url (ex. `/service-map`).

Related hubble-ui pull request:
cilium/hubble-ui#432

Signed-off-by: Dmitry Kharitonov<dmitry@isovalent.com>
Signed-off-by: Tobias Klauser <tobias@cilium.io>
[ upstream commit e980ca0 ]

Signed-off-by: Dmitry Kharitonov <dmitry@isovalent.com>
Signed-off-by: Tobias Klauser <tobias@cilium.io>
[ upstream commit 788bf37 ]

By right there should be a rule to let ipsec skb bypass conntrack:

-A CILIUM_PRE_raw -m mark --mark 0xd00/0xf00 -m comment --comment "cilium-xfrm-notrack:" -j CT --notrack

However ipv6 missed it and this commit adds the rule back.

Fixes: cilium#23481

Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser requested a review from a team as a code owner March 28, 2023 12:32
@tklauser tklauser added kind/backports This PR provides functionality previously merged into master. backport/1.11 This PR represents a backport for Cilium 1.11.x of a PR that was merged to main. labels Mar 28, 2023
@tklauser
Copy link
Member Author

tklauser commented Mar 28, 2023

/test-backport-1.11

Job 'Cilium-PR-K8s-1.19-kernel-4.9' hit: #22555 (92.92% similarity)

Job 'Cilium-PR-K8s-1.17-kernel-4.9' failed:

Click to show.

Test Name

K8sVerifier Runs the kernel verifier against Cilium's BPF datapath

Failure Output

FAIL: Failed to load BPF program bpf_lxc with datapath configuration:

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.17-kernel-4.9 so I can create one.

Job 'Cilium-PR-K8s-1.17-kernel-4.9' has 1 failure but they might be new flake since it also hit 1 known flake: #22555 (92.92)

Job 'Cilium-PR-K8s-1.19-kernel-4.9' hit: #23365 (94.07% similarity)

Job 'Cilium-PR-K8s-1.17-kernel-4.9' hit: #22555 (92.92% similarity)

@tklauser
Copy link
Member Author

/test-1.21-4.9

@tklauser
Copy link
Member Author

/test-1.19-4.9

@tklauser
Copy link
Member Author

/test-1.17-4.9

@tklauser
Copy link
Member Author

/test-1.19-4.9

@tklauser
Copy link
Member Author

/test-1.17-4.9

@tklauser
Copy link
Member Author

Cilium-PR-K8s-1.17-kernel-4.9' hit known flake #22555, all other tests passed and most reviews are in. Marking as ready to merge.

@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 29, 2023
@julianwiedmann julianwiedmann merged commit fe958b5 into cilium:v1.11 Mar 29, 2023
@tklauser tklauser deleted the pr/v1.11-backport-2023-03-28 branch March 29, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.11 This PR represents a backport for Cilium 1.11.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants