pkg: add missing xfrm-no-track rules from ipv6 #24557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By right there should be a rule to let ipsec skb bypass conntrack: -A CILIUM_PRE_raw -m mark --mark 0xd00/0xf00 -m comment --comment "cilium-xfrm-notrack:" -j CT --notrack However ipv6 missed it and this commit adds the rule back. Fixes: cilium#23481 Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
jschwinger233
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
This reverts commit b1b9fbd and re-enables test for IPv6 externalTrafficPolicy=Local E/W for IPsec. Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
|
/test |
pchaigno
added
area/encryption
pchaigno
reviewed
Mar 24, 2023
There was a problem hiding this comment.
Nice! Thanks for tracking and fixing this!
I see it's labeled as release-note/minor, but it feels more like a release-note/bug, no? The release note should also describe the user impact. It currently describes the change itself.
Finally, I think we should figure out where we need to backport.
jschwinger233
added
release-note/bug
I noticed there is no PR labelled with |
|
[word-smith'ed the release-note. Also adding backport labels for 1.12 and 1.13] |
julianwiedmann
added
sig/datapath
pchaigno
approved these changes
Mar 27, 2023
|
Backport PR will be taken care of by renovate bot, right? Is there anything I should follow up? |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.11
in 1.11.16
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.11
in 1.11.16
tklauser
added
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.13
in 1.13.2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.13
in 1.13.2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.12
in 1.12.9
tklauser
added
backport-done/1.12
maintainer-s-little-helper
bot
moved this from Backport pending to v1.12
to Backport done to v1.12
in 1.12.9
tklauser
added
backport-done/1.11
maintainer-s-little-helper
bot
moved this from Backport pending to v1.11
to Backport done to v1.11
in 1.11.16
This was referenced Apr 14, 2023
julianwiedmann
added
backport-done/1.13
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Backport done to v1.13
in 1.13.2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Backport done to v1.13
in 1.13.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By right there should be a rule to let ipsec skb bypass conntrack:
-A CILIUM_PRE_raw -m mark --mark 0xd00/0xf00 -m comment --comment "cilium-xfrm-notrack:" -j CT --notrack
However ipv6 missed it and this commit adds the rule back.
Fixes: #23481