Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: lxc: fix one missing drop notification in CT lookup tail calls #26115

Merged
merged 1 commit into from
Jun 13, 2023
Merged

bpf: lxc: fix one missing drop notification in CT lookup tail calls #26115

merged 1 commit into from
Jun 13, 2023

Conversation

julianwiedmann
Copy link
Member

@julianwiedmann julianwiedmann commented Jun 12, 2023 •
edited

b2de07a ("bpf: Fix missing drop notifications on ct lookup failures") took care of most paths. But we also need to throw a drop notification when ipv6_hdrlen() returns an error.

@julianwiedmann
bpf: lxc: fix one missing drop notification in CT lookup tail calls
80fb047 
b2de07a ("bpf: Fix missing drop notifications on ct lookup failures")
took care of most paths. But we also need to throw a drop notification when
ipv6_hdrlen() returns an error.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added kind/bug This is a bug in the Cilium logic. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/bug This PR fixes an issue in a previous release of Cilium. needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jun 12, 2023
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann marked this pull request as ready for review June 13, 2023 05:49
@julianwiedmann julianwiedmann requested a review from a team as a code owner June 13, 2023 05:49
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 13, 2023
@julianwiedmann
Copy link
Member Author

ci-gingko fails are a mix of #25964 and #26009.

@julianwiedmann julianwiedmann merged commit 458479b into cilium:main Jun 13, 2023
65 of 66 checks passed
@julianwiedmann julianwiedmann deleted the 1.14-bpf-drop-notify branch June 13, 2023 08:52
@michi-covalent michi-covalent mentioned this pull request Jun 13, 2023
Closed
7 tasks
@nbusseneau nbusseneau mentioned this pull request Jun 22, 2023
Merged
19 tasks
@nbusseneau nbusseneau added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jun 22, 2023
@tklauser tklauser added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Jun 29, 2023
@gentoo-root gentoo-root mentioned this pull request Jul 26, 2023
Merged
@sayboras sayboras mentioned this pull request Oct 2, 2023
Merged
2 tasks
@julianwiedmann julianwiedmann added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Oct 5, 2023
@jrajahalme jrajahalme mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aspsk aspsk aspsk approved these changes

Assignees
No one assigned
Labels
backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@julianwiedmann @aspsk @tklauser @nbusseneau @sayboras