Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fqdn proxy: fix data race detection on TCP fqdn proxy #28219

Merged
merged 1 commit into from
Sep 25, 2023
Merged

fqdn proxy: fix data race detection on TCP fqdn proxy #28219

merged 1 commit into from
Sep 25, 2023

Commits on Sep 19, 2023

  1. fqdn proxy: fix data race detection on TCP fqdn proxy 

    PR cilium#25309 introduced a data race by sharing the sessionUDPFactory between
the DNS server instances for the different IP families (IPv4 & IPv6).
This has been detected by cilium#27979.

This commit fixes the issue for the TCP servers too. It not set explicitly,
these are initialized with the default udp session factory to prevent nil
pointer exceptions. Therefore, an explicit noop udp session factory is set.

Fixes: cilium#28156

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
    @mhofstetter
    mhofstetter committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    bd5cacb View commit details
    Browse the repository at this point in the history