Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for filtering on HTTP URLs in Hubble #28275

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Add support for filtering on HTTP URLs in Hubble #28275

merged 1 commit into from
Sep 28, 2023

Conversation

glrf
Copy link
Contributor

@glrf glrf commented Sep 26, 2023

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.

Adds a new http_urls filter that matches the whole HTTP URL using regular expressions. This works similarly to the existing http_paths filter, but instead of matching the path, it matches the whole URL

Implements the server side changes for cilium/hubble#925

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 26, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Sep 26, 2023
@glrf
hubble: support filtering on HTTP URL
cee99ff 
Adds a new `http_urls` filter that matches the whole HTTP URL using
regular expressions. This works similarly to the existing `http_paths`
filter, but instead of matching the path, it matches the whole URL

Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
@glrf glrf changed the title hubble: support filtering on HTTP URL Add support for filtering on HTTP URLs in Hubble Sep 26, 2023
@glrf glrf marked this pull request as ready for review September 26, 2023 09:15
@glrf glrf requested review from a team as code owners September 26, 2023 09:16
@glrf glrf requested a review from kaworu September 26, 2023 09:16
@kaworu kaworu added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/hubble Impacts hubble server or relay labels Sep 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Sep 26, 2023
@kaworu kaworu added kind/feature This introduces new functionality. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Sep 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Sep 26, 2023
kaworu
kaworu approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaworu kaworu requested a review from rolinh September 26, 2023 12:59
rolinh
rolinh approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for your contribution!

@rolinh
Copy link
Member

rolinh commented Sep 28, 2023

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 28, 2023
@rolinh rolinh merged commit f397226 into cilium:main Sep 28, 2023
59 of 61 checks passed
glrf added a commit to glrf/hubble that referenced this pull request Oct 2, 2023
@glrf
Add HTTP URL filter
4c93259 
We added support for filtering on HTTP URLs in
cilium/cilium#28275. This PR adds this feature
in the CLI by adding a new flag `--http-url`

Fixes: cilium#925

Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
@glrf glrf mentioned this pull request Oct 2, 2023
Merged
glrf added a commit to glrf/hubble that referenced this pull request Oct 2, 2023
@glrf
Add HTTP URL filter
f942083 
We added support for filtering on HTTP URLs in
cilium/cilium#28275. This PR adds this feature
in the CLI by adding a new flag `--http-url`

Fixes: cilium#925

Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
glrf added a commit to glrf/hubble that referenced this pull request Oct 2, 2023
@glrf
Add HTTP URL filter
8338d48 
We added support for filtering on HTTP URLs in
cilium/cilium#28275. This PR adds this feature
in the CLI by adding a new flag `--http-url`

Fixes: cilium#925

Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
glrf added a commit to glrf/hubble that referenced this pull request Oct 2, 2023
@glrf
Add HTTP URL filter
e4b66e0 
We added support for filtering on HTTP URLs in
cilium/cilium#28275. This PR adds this feature
in the CLI by adding a new flag `--http-url`

Fixes: cilium#925

Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
glrf added a commit to glrf/hubble that referenced this pull request Oct 2, 2023
@glrf
Add HTTP URL filter
2eda984 
We added support for filtering on HTTP URLs in
cilium/cilium#28275. This PR adds this feature
in the CLI by adding a new flag `--http-url`

Fixes: cilium#925

Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
glrf added a commit to glrf/hubble that referenced this pull request Oct 9, 2023
@glrf
Add HTTP URL filter
50ff747 
We added support for filtering on HTTP URLs in
cilium/cilium#28275. This PR adds this feature
in the CLI by adding a new flag `--http-url`

Fixes: cilium#925

Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
glrf added a commit to glrf/hubble that referenced this pull request Oct 16, 2023
@glrf
Add HTTP URL filter
5c82357 
We added support for filtering on HTTP URLs in
cilium/cilium#28275. This PR adds this feature
in the CLI by adding a new flag `--http-url`

Fixes: cilium#925

Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
kaworu pushed a commit to cilium/hubble that referenced this pull request Oct 20, 2023
@glrf @kaworu
Add HTTP URL filter
6abc2a8 
We added support for filtering on HTTP URLs in
cilium/cilium#28275. This PR adds this feature
in the CLI by adding a new flag `--http-url`

Fixes: #925

Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaworu kaworu kaworu approved these changes

@rolinh rolinh rolinh approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. kind/feature This introduces new functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/hubble Impacts hubble server or relay
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@glrf @rolinh @kaworu