Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for filtering on HTTP URL #925

Closed
chancez opened this issue Mar 9, 2023 · 2 comments · Fixed by #1236
Closed

Support for filtering on HTTP URL #925

chancez opened this issue Mar 9, 2023 · 2 comments · Fixed by #1236
Labels
area/cilium Requires upstream work in Cilium 👍 good-first-issue Good starting point for new developers, which requires minimal understanding of Hubble. 🌟 kind/feature This introduces new functionality.

Comments

@chancez
Copy link
Contributor

chancez commented Mar 9, 2023 •
edited
Loading

Currently we support filtering on the HTTP URL Path, but not the entire URL. We should support filtering again the entireflow.l7.http.url. It contains additional information beyond the URL path, such as the domain, and the protocol. (http/https).
@chancez chancez added 👍 good-first-issue Good starting point for new developers, which requires minimal understanding of Hubble. 🌟 kind/feature This introduces new functionality. labels Mar 9, 2023
@kaworu kaworu added the area/cilium Requires upstream work in Cilium label Mar 9, 2023
@azepecki
Copy link

azepecki commented May 3, 2023

I would like to help with this one if it could be assigned to me! Thank you

@azepecki azepecki mentioned this issue May 3, 2023
Closed
@kaworu
Copy link
Member

kaworu commented Sep 11, 2023

@azepecki Hi 👋 are you still intending to work on this?

@glrf glrf mentioned this issue Sep 26, 2023
Merged
5 tasks
glrf added a commit to glrf/hubble that referenced this issue Oct 2, 2023
@glrf
Add HTTP URL filter
4c93259 
We added support for filtering on HTTP URLs in
cilium/cilium#28275. This PR adds this feature
in the CLI by adding a new flag `--http-url`

Fixes: cilium#925

Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
@glrf glrf mentioned this issue Oct 2, 2023
Merged
glrf added a commit to glrf/hubble that referenced this issue Oct 2, 2023
@glrf
Add HTTP URL filter
f942083 
We added support for filtering on HTTP URLs in
cilium/cilium#28275. This PR adds this feature
in the CLI by adding a new flag `--http-url`

Fixes: cilium#925

Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
glrf added a commit to glrf/hubble that referenced this issue Oct 2, 2023
@glrf
Add HTTP URL filter
8338d48 
We added support for filtering on HTTP URLs in
cilium/cilium#28275. This PR adds this feature
in the CLI by adding a new flag `--http-url`

Fixes: cilium#925

Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
glrf added a commit to glrf/hubble that referenced this issue Oct 2, 2023
@glrf
Add HTTP URL filter
e4b66e0 
We added support for filtering on HTTP URLs in
cilium/cilium#28275. This PR adds this feature
in the CLI by adding a new flag `--http-url`

Fixes: cilium#925

Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
glrf added a commit to glrf/hubble that referenced this issue Oct 2, 2023
@glrf
Add HTTP URL filter
2eda984 
We added support for filtering on HTTP URLs in
cilium/cilium#28275. This PR adds this feature
in the CLI by adding a new flag `--http-url`

Fixes: cilium#925

Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
glrf added a commit to glrf/hubble that referenced this issue Oct 9, 2023
@glrf
Add HTTP URL filter
50ff747 
We added support for filtering on HTTP URLs in
cilium/cilium#28275. This PR adds this feature
in the CLI by adding a new flag `--http-url`

Fixes: cilium#925

Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
glrf added a commit to glrf/hubble that referenced this issue Oct 16, 2023
@glrf
Add HTTP URL filter
5c82357 
We added support for filtering on HTTP URLs in
cilium/cilium#28275. This PR adds this feature
in the CLI by adding a new flag `--http-url`

Fixes: cilium#925

Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
kaworu pushed a commit that referenced this issue Oct 20, 2023
@glrf @kaworu
Add HTTP URL filter
6abc2a8 
We added support for filtering on HTTP URLs in
cilium/cilium#28275. This PR adds this feature
in the CLI by adding a new flag `--http-url`

Fixes: #925

Signed-off-by: Fabian Fischer <fabian.fischer@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/cilium Requires upstream work in Cilium 👍 good-first-issue Good starting point for new developers, which requires minimal understanding of Hubble. 🌟 kind/feature This introduces new functionality.
Projects
Good First Issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add HTTP URL filter glrf/hubble
3 participants
@kaworu @chancez @azepecki