v1.12 backports 2023-10-02 #28351
Merged
v1.12 backports 2023-10-02 #28351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayboras
added
kind/backports
|
Note that the BPF fix will need #28295 to land first. |
You beat me to this. Yes, I noticed the pending backport PR, so just mark this one as draft. |
julianwiedmann
approved these changes
Oct 2, 2023
[ upstream commit 458479b ] b2de07a ("bpf: Fix missing drop notifications on ct lookup failures") took care of most paths. But we also need to throw a drop notification when ipv6_hdrlen() returns an error. Signed-off-by: Julian Wiedmann <jwi@isovalent.com> Signed-off-by: Tam Mach <tam.mach@cilium.io>
[ upstream commit cc56e70 ] These resources are enabled in cilum-proxy build, and can be used in CiliumEnvoyConfig directly, however, without related imported statements, Cilium agent will fail to marshal/unmarshal objects. Sample error ``` level=warning msg="Ignoring invalid CiliumEnvoyConfig JSON (proto:\u00a0(line 1:405): unable to resolve \"type.googleapis.com/envoy.extensions.filters.http.router.v3.Router\": \"not found\") ``` Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
force-pushed
the
pr/v1.12-backport-2023-10-02
branch
from
606ae53
to
f2626bf
Compare
|
/test-backport-1.12 |
sayboras
added
the
ready-to-merge
|
Reviews are in, CI is also great, marking this ready to merge. |
ti-mo
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, you can update the PR labels via: