[v1.13] loader: explicitly insert endpoint policy programs into policy maps #29309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-mo
added
release-note/bug
ti-mo
changed the title
|
/test-backport-1.13 |
ti-mo
force-pushed
the
tb/v1.13-policy-progs
branch
2 times, most recently
from
18f47f0
to
c39687a
Compare
|
/test-backport-1.13 |
ti-mo
force-pushed
the
tb/v1.13-policy-progs
branch
from
c39687a
to
935343b
Compare
|
/test-backport-1.13 |
[ upstream commit 4098439 ] BPF ELF loaders generally populate maps in a non-deterministic order when it comes to the order of the maps themselves. During some loads, cilium_calls may be populated first, sometimes cilium_(egress)call_policy gets populated first. The latter case is a problem since existing endpoints will constantly get their cilium_call_policy entry invoked for incoming packets. If its tail call map(s) are not yet populated, that will result in missed tail calls leading to packet drops. This commit zeroes the call maps' MapSpec.Contents and manually resolves []MapKV to the referenced policy progs, both for ingress and egress (l7) handlers. Policy programs are explicitly inserted into the respective call maps after the entrypoint(s) have been attached. This calls for major refactoring -- inserting the policy program is equal to attaching an entrypoint to a BPF hook and should be done explicitly by an endpoint manager that has access to the Endpoint object. This would make extracting the endpoint ID from the ELF section name redundant. Signed-off-by: Timo Beckers <timo@isovalent.com>
ti-mo
force-pushed
the
tb/v1.13-policy-progs
branch
from
935343b
to
dffcde6
Compare
|
/test-backport-1.13 |
1 similar comment
|
/test-backport-1.13 |
lmb
approved these changes
Nov 22, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
brb
added a commit
that referenced
this pull request
Nov 22, 2023
The issue got fixed by #29309. Signed-off-by: Martynas Pumputis <m@lambda.lt>
pchaigno
pushed a commit
that referenced
this pull request
Nov 22, 2023
The issue got fixed by #29309. Signed-off-by: Martynas Pumputis <m@lambda.lt>
pjablonski123
pushed a commit
to pjablonski123/cilium
that referenced
this pull request
Dec 15, 2023
The issue got fixed by cilium#29309. Signed-off-by: Martynas Pumputis <m@lambda.lt>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #29307.