ci-ipsec-upgrade: Drop no-missed-tail-calls exclusion #29325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue got fixed by #29309. Signed-off-by: Martynas Pumputis <m@lambda.lt>
brb
added
area/CI
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
|
/ci-ipsec-upgrade |
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
pchaigno
approved these changes
Nov 22, 2023
pchaigno
approved these changes
Nov 22, 2023
brb
added
the
ready-to-merge
|
@qmonnet I'm not sure about the v1.13 -> v1.12 downgrade, as the loader fix was backported only to v1.1{3,4}. Mind giving a go though? Maybe loading with iproute2 is more deterministic, so that we don't run into those cilium_calls vs cilium_call_policy issues. |
|
Ah true we downgrade to 1.12 but the fix is not on that branch. |
1 task
joamaki
added
backport-pending/1.14
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.5
github-actions
bot
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue got fixed by #29309.