test: Fail ginkgo tests on warnings #29624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
area/CI-improvement
pchaigno
force-pushed
the
ginkgo-fail-on-warnings
branch
21 times, most recently
from
fd34ccd
to
a4c5b7d
Compare
Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
We need to allowlist the following warning because it's expected in our
Kind-based CI:
level=warning msg="Unable to ensure that BPF JIT compilation is
enabled. This can be ignored when Cilium is running inside
non-host network namespace (e.g. with kind or minikube)"
error="could not open the sysctl file
/host/proc/sys/net/core/bpf_jit_enable: open
/host/proc/sys/net/core/bpf_jit_enable: no such file or
directory" subsys=sysctl sysParamName=net.core.bpf_jit_enable
sysParamValue=1
Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
We currently have a lot of warnings in the ginkgo tests because we're using the old, deprecated values for the kubeProxyReplacement flag. This commit fixes it. Fixes: 996331d ("Revert "Revert "agent: Add --kube-proxy-replacement=true|false""") Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
If we don't do that, we'll end up with:
level=warning msg="Falling back to iptables-based masquerading."
error="BPF masquerade requires NodePort (--enable-node-port=\"true\")"
subsys=daemon
Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
We have many different warnings happening in CI. Let's allowlist them for now, so we can at least enforce the new check and stop the bleeding. Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
pchaigno
force-pushed
the
ginkgo-fail-on-warnings
branch
from
a4c5b7d
to
3b9d70e
Compare
sayboras
approved these changes
Dec 10, 2023
Me neither (except the ones related to datapath 😅). I opened issues for all of them if they required further investigation. My goal for now is really just to stop the bleeding, not to make a judgement call on whether any of these are legitimate or require fixes. That will take more time. |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the ginkgo tests fail on any level=warning agent or operator log. See commits for details.
I had to allowlist a bunch of warnings so we can at least stop the bleeding before we fix them. I ran the full ginkgo suite 12 times without any new warnings popping up so we should be good to go.