Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ginkgo: Switch --kpr to boolean #29695

Closed
wants to merge 1 commit into from
Closed

ginkgo: Switch --kpr to boolean #29695

wants to merge 1 commit into from

Conversation

brb
Copy link
Member

@brb brb commented Dec 7, 2023

"strict" and "disabled" were deprecated in
#26496.

Reported-by: Paul Chaignon paul.chaignon@gmail.com

"strict" and "disabled" were deprecated in
#26496.

Reported-by: Paul Chaignon <paul.chaignon@gmail.com>
Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb added kind/bug/CI This is a bug in the testing code. needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Dec 7, 2023
@brb brb requested review from a team as code owners December 7, 2023 13:36
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.5 Dec 7, 2023
@brb
Copy link
Member Author

brb commented Dec 7, 2023

/ci-ginkgo

Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're missing two. See 6697efb.

@brb brb added the release-note/ci This PR makes changes to the CI. label Dec 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Dec 7, 2023
@pchaigno
Copy link
Member

Addressed in #29624.

@pchaigno pchaigno closed this Dec 11, 2023
@nebril nebril added this to Needs backport from main in 1.14.6 Dec 11, 2023
@nebril nebril removed this from Needs backport from main in 1.14.5 Dec 11, 2023
@gentoo-root gentoo-root added this to Needs backport from main in 1.14.7 Jan 17, 2024
@gentoo-root gentoo-root removed this from Needs backport from main in 1.14.6 Jan 17, 2024
@michi-covalent michi-covalent added this to Needs backport from main in 1.14.8 Feb 13, 2024
@michi-covalent michi-covalent removed this from Needs backport from main in 1.14.7 Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug/CI This is a bug in the testing code. needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.14.8
Needs backport from main
Development

Successfully merging this pull request may close these issues.

None yet

4 participants